Closed Bug 673499 Opened 10 years ago Closed 9 years ago

Remove Whitespace


(Core :: JavaScript Engine, defect)

Not set





(Reporter: evilpie, Assigned: evilpie)



(1 file, 2 obsolete files)

No description provided.
Attached patch remove whitespace (obsolete) — Splinter Review
Attached patch remove trailing whitespace (obsolete) — Splinter Review
Attachment #547762 - Attachment is obsolete: true
Attachment #547792 - Flags: review?(Ms2ger)
Comment on attachment 547792 [details] [diff] [review]
remove trailing whitespace

Leave ctypes/libffi.patch and ctypes/libffi/* alone. If you're going to touch /js/src/, check if you need to update / as well. Maybe leave xpconnect/ alone as well, and yarr/ if we update it from upstream.

r=me with those changes, but keep in mind I'm technically not qualified to review stuff.
Attachment #547792 - Flags: review?(Ms2ger) → review+
Comment on attachment 547792 [details] [diff] [review]
remove trailing whitespace

This patch is too broad.

I'd review a patch restricted to C/C++ files in js/src and the subdirectories js/src/{vm,methodjit,tracejit,shell}.

I'd also be willing to review a separate patch restricted to js/src/{jit-test,tests,jsapi-tests}, but it's maybe not such a bad thing to have a few tests that contain trailing whitespace; some of those may even be intentional.

Much of the rest is code other teams are responsible for, sometimes copied from upstream sources. We should not make unnecessary changes there.
Attachment #547792 - Flags: review+ → review-
If it helps at all, the js/src/ build system whitespace cleanup will be dealt with by Matheus' patch in bug 671465.
Assignee: general → evilpies
Attached patch smaller patchSplinter Review
Attachment #547792 - Attachment is obsolete: true
Attachment #624398 - Flags: review?(jorendorff)
Comment on attachment 624398 [details] [diff] [review]
smaller patch

Review of attachment 624398 [details] [diff] [review]:

r=me with one comment.

::: js/src/
@@ +23,5 @@
>            <event symbol="EvtExecuteDone" value="1002" version="1"
>                   channel="MozillaChannel" level="win:Informational"
>                   template="CodeLocationTemplate" task="Execution" opcode="ExecuteStop"
>                   keywords="SampleKeyword" message="$(string.MozillaSpiderMonkey.ExecuteDone.message)"/>
> +

I have no idea what this file is. Surely this is autogenerated by some Microsoft tool that puts in the useless spaces, and the spaces will only come back the next time this is updated.

In any case you don't want your name on this file's changelog. Please revert this one.
Attachment #624398 - Flags: review?(jorendorff) → review+
And reverting the change to js/src/, which I accidentally did not remove after some rebasing action.
Target Milestone: --- → mozilla15
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.