Created attachment 547844 [details] [diff] [review] Add JS libs into link of tests xpcom/tests/TestHarness.h conditionally #includes "jsdbgapi.h" if MOZ_SHARK is defined, so that it can call JS_StartProfiling. libmozjs.so (eg) is not included on the link of the tests that use TestHarness.h. khuey says the attached is the right fix. I don't really understand why it was working without --enable-shared-js, and if it was because the JS lib was included in libxul.so, then I don't understand why this wouldn't cause duplicate symbols or something. I'm hoping I'll never have to understand. I am changing the profiling stuff around substantially. This fix will be necessary to avoid --enable-shared-js *always* breaking the test builds, which would suck.
Comment on attachment 547844 [details] [diff] [review] Add JS libs into link of tests NB: You need to make the same change to js/src/config/rules.mk, or you will anger the copy-paste test in make check.
Mirrored the changes to js/src, thanks. http://hg.mozilla.org/integration/mozilla-inbound/rev/8f591ae20300
For what it's worth, the fix for this bug is wrong and broke win64 on the landing of bug 702179. The issue will be resolved there.