TestNativeXMLHttpRequest.exe : fatal error LNK1120: 6 unresolved externals

RESOLVED FIXED in mozilla9

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Armen - back on June 11th, Assigned: m_kato)

Tracking

(Blocks: 2 bugs)

Trunk
mozilla9
x86_64
Windows Server 2008
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
c:/mozilla-build/python/python2.6.exe /e/builds/moz2_slave/m-cen-w64/build/config/pythonpath.py -I../../../config /e/builds/moz2_slave/m-cen-w64/build/config/expandlibs_exec.py --uselist -- link -nologo -out:TestNativeXMLHttpRequest.exe -pdb:TestNativeXMLHttpRequest.pdb TestNativeXMLHttpRequest.obj  -LARGEADDRESSAWARE -NXCOMPAT -DYNAMICBASE  -DEBUG -DEBUGTYPE:CV -DEBUG -OPT:REF,ICF -MANIFEST:NO -LIBPATH:"e:/builds/moz2_slave/m-cen-w64/build/obj-firefox/memory/jemalloc/crtsrc/build/amd64" -NODEFAULTLIB:msvcrt -NODEFAULTLIB:msvcrtd -NODEFAULTLIB:msvcprt -NODEFAULTLIB:msvcprtd -DEFAULTLIB:mozcrt19 -DEFAULTLIB:mozcpp19   e:/builds/moz2_slave/m-cen-w64/build/obj-firefox/dist/lib/xpcomglue_s.lib e:/builds/moz2_slave/m-cen-w64/build/obj-firefox/dist/lib/xpcom.lib e:/builds/moz2_slave/m-cen-w64/build/obj-firefox/dist/lib/mozalloc.lib e:/builds/moz2_slave/m-cen-w64/build/obj-firefox/dist/lib/nspr4.lib e:/builds/moz2_slave/m-cen-w64/build/obj-firefox/dist/lib/plc4.lib e:/builds/moz2_slave/m-cen-w64/build/obj-firefox/dist/lib/plds4.lib  e:/builds/moz2_slave/m-cen-w64/build/obj-firefox/dist/lib/js_static.lib  kernel32.lib user32.lib gdi32.lib winmm.lib wsock32.lib advapi32.lib
xpcomglue_s.lib(nsComponentManagerUtils.obj) : MSIL .netmodule or module compiled with /GL found; restarting link with /LTCG; add /LTCG to the link command line to improve linker performance
TestNativeXMLHttpRequest.obj : error LNK2001: unresolved external symbol __imp_JS_PropertyStub
TestNativeXMLHttpRequest.obj : error LNK2001: unresolved external symbol __imp_JS_StrictPropertyStub
TestNativeXMLHttpRequest.obj : error LNK2001: unresolved external symbol __imp_JS_EnumerateStub
TestNativeXMLHttpRequest.obj : error LNK2001: unresolved external symbol __imp_JS_ResolveStub
TestNativeXMLHttpRequest.obj : error LNK2001: unresolved external symbol __imp_JS_ConvertStub
TestNativeXMLHttpRequest.obj : error LNK2001: unresolved external symbol __imp_JS_FinalizeStub
TestNativeXMLHttpRequest.exe : fatal error LNK1120: 6 unresolved externals
make[7]: Leaving directory `/e/builds/moz2_slave/m-cen-w64/build/obj-firefox/content/base/test'
make[7]: *** [TestNativeXMLHttpRequest.exe] Error 96
make[6]: Leaving directory `/e/builds/moz2_slave/m-cen-w64/build/obj-firefox/content/base'
make[6]: *** [tools] Error 2
make[5]: *** [base_tools] Error 2
make[5]: Leaving directory `/e/builds/moz2_slave/m-cen-w64/build/obj-firefox/content'
make[4]: *** [tools_tier_platform] Error 2
make[4]: Leaving directory `/e/builds/moz2_slave/m-cen-w64/build/obj-firefox'
make[3]: Leaving directory `/e/builds/moz2_slave/m-cen-w64/build/obj-firefox'
make[3]: *** [tier_platform] Error 2
make[2]: *** [default] Error 2
make[2]: Leaving directory `/e/builds/moz2_slave/m-cen-w64/build/obj-firefox'
make[1]: Leaving directory `/e/builds/moz2_slave/m-cen-w64/build'
make[1]: *** [realbuild] Error 2
make: *** [profiledbuild] Error 2
Something is busted here, we're linking against js_static.lib but expecting to find import symbols.
(Assignee)

Updated

6 years ago
Blocks: 673616
(Assignee)

Updated

6 years ago
No longer blocks: 673616
(Assignee)

Updated

6 years ago
Assignee: nobody → m_kato
(Assignee)

Comment 2

6 years ago
When including TestHarness.h, this occurs.  TestHarness includes jsdbgapi.h, then jsdbgapi.h inclues jsopcode.h, then jsopcode.h includes jsvalue.h...  Including jsvalue.h causes build break when using --disable-shared-js.

This is a regression of bug 673631.
Blocks: 673631
(Assignee)

Comment 3

6 years ago
Created attachment 553679 [details] [diff] [review]
fix
(Assignee)

Updated

6 years ago
Attachment #553679 - Flags: review?(khuey)
Comment on attachment 553679 [details] [diff] [review]
fix

This looks fine, but why isn't the 32 bit build affected?
Attachment #553679 - Flags: review?(khuey) → review+
(Assignee)

Comment 5

6 years ago
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #4)
> Comment on attachment 553679 [details] [diff] [review]
> fix
> 
> This looks fine, but why isn't the 32 bit build affected?

If we use --disable-shared-js on Win32, same issue occurs.
(In reply to Makoto Kato from comment #5)
> (In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #4)
> > Comment on attachment 553679 [details] [diff] [review]
> > fix
> > 
> > This looks fine, but why isn't the 32 bit build affected?
> 
> If we use --disable-shared-js on Win32, same issue occurs.

Ah, disable-shared, not enable-shared ... that would explain it.
(Reporter)

Comment 7

6 years ago
Is this ready to check-in?
(Assignee)

Comment 8

6 years ago
http://hg.mozilla.org/mozilla-central/rev/7054f0e3e70e
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
(Assignee)

Updated

6 years ago
Target Milestone: mozilla8 → mozilla9
You need to log in before you can comment on or make changes to this bug.