Last Comment Bug 679473 - TestNativeXMLHttpRequest.exe : fatal error LNK1120: 6 unresolved externals
: TestNativeXMLHttpRequest.exe : fatal error LNK1120: 6 unresolved externals
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86_64 Windows Server 2008
: -- normal (vote)
: mozilla9
Assigned To: Makoto Kato [:m_kato]
:
:
Mentors:
http://tbpl.allizom.org/php/getParsed...
Depends on:
Blocks: tracking_win64 support-win64 673631
  Show dependency treegraph
 
Reported: 2011-08-16 13:11 PDT by Armen Zambrano [:armenzg] (EDT/UTC-4)
Modified: 2011-08-17 17:38 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (971 bytes, patch)
2011-08-16 22:03 PDT, Makoto Kato [:m_kato]
khuey: review+
Details | Diff | Splinter Review

Description Armen Zambrano [:armenzg] (EDT/UTC-4) 2011-08-16 13:11:38 PDT
c:/mozilla-build/python/python2.6.exe /e/builds/moz2_slave/m-cen-w64/build/config/pythonpath.py -I../../../config /e/builds/moz2_slave/m-cen-w64/build/config/expandlibs_exec.py --uselist -- link -nologo -out:TestNativeXMLHttpRequest.exe -pdb:TestNativeXMLHttpRequest.pdb TestNativeXMLHttpRequest.obj  -LARGEADDRESSAWARE -NXCOMPAT -DYNAMICBASE  -DEBUG -DEBUGTYPE:CV -DEBUG -OPT:REF,ICF -MANIFEST:NO -LIBPATH:"e:/builds/moz2_slave/m-cen-w64/build/obj-firefox/memory/jemalloc/crtsrc/build/amd64" -NODEFAULTLIB:msvcrt -NODEFAULTLIB:msvcrtd -NODEFAULTLIB:msvcprt -NODEFAULTLIB:msvcprtd -DEFAULTLIB:mozcrt19 -DEFAULTLIB:mozcpp19   e:/builds/moz2_slave/m-cen-w64/build/obj-firefox/dist/lib/xpcomglue_s.lib e:/builds/moz2_slave/m-cen-w64/build/obj-firefox/dist/lib/xpcom.lib e:/builds/moz2_slave/m-cen-w64/build/obj-firefox/dist/lib/mozalloc.lib e:/builds/moz2_slave/m-cen-w64/build/obj-firefox/dist/lib/nspr4.lib e:/builds/moz2_slave/m-cen-w64/build/obj-firefox/dist/lib/plc4.lib e:/builds/moz2_slave/m-cen-w64/build/obj-firefox/dist/lib/plds4.lib  e:/builds/moz2_slave/m-cen-w64/build/obj-firefox/dist/lib/js_static.lib  kernel32.lib user32.lib gdi32.lib winmm.lib wsock32.lib advapi32.lib
xpcomglue_s.lib(nsComponentManagerUtils.obj) : MSIL .netmodule or module compiled with /GL found; restarting link with /LTCG; add /LTCG to the link command line to improve linker performance
TestNativeXMLHttpRequest.obj : error LNK2001: unresolved external symbol __imp_JS_PropertyStub
TestNativeXMLHttpRequest.obj : error LNK2001: unresolved external symbol __imp_JS_StrictPropertyStub
TestNativeXMLHttpRequest.obj : error LNK2001: unresolved external symbol __imp_JS_EnumerateStub
TestNativeXMLHttpRequest.obj : error LNK2001: unresolved external symbol __imp_JS_ResolveStub
TestNativeXMLHttpRequest.obj : error LNK2001: unresolved external symbol __imp_JS_ConvertStub
TestNativeXMLHttpRequest.obj : error LNK2001: unresolved external symbol __imp_JS_FinalizeStub
TestNativeXMLHttpRequest.exe : fatal error LNK1120: 6 unresolved externals
make[7]: Leaving directory `/e/builds/moz2_slave/m-cen-w64/build/obj-firefox/content/base/test'
make[7]: *** [TestNativeXMLHttpRequest.exe] Error 96
make[6]: Leaving directory `/e/builds/moz2_slave/m-cen-w64/build/obj-firefox/content/base'
make[6]: *** [tools] Error 2
make[5]: *** [base_tools] Error 2
make[5]: Leaving directory `/e/builds/moz2_slave/m-cen-w64/build/obj-firefox/content'
make[4]: *** [tools_tier_platform] Error 2
make[4]: Leaving directory `/e/builds/moz2_slave/m-cen-w64/build/obj-firefox'
make[3]: Leaving directory `/e/builds/moz2_slave/m-cen-w64/build/obj-firefox'
make[3]: *** [tier_platform] Error 2
make[2]: *** [default] Error 2
make[2]: Leaving directory `/e/builds/moz2_slave/m-cen-w64/build/obj-firefox'
make[1]: Leaving directory `/e/builds/moz2_slave/m-cen-w64/build'
make[1]: *** [realbuild] Error 2
make: *** [profiledbuild] Error 2
Comment 1 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-08-16 13:13:29 PDT
Something is busted here, we're linking against js_static.lib but expecting to find import symbols.
Comment 2 Makoto Kato [:m_kato] 2011-08-16 21:47:48 PDT
When including TestHarness.h, this occurs.  TestHarness includes jsdbgapi.h, then jsdbgapi.h inclues jsopcode.h, then jsopcode.h includes jsvalue.h...  Including jsvalue.h causes build break when using --disable-shared-js.

This is a regression of bug 673631.
Comment 3 Makoto Kato [:m_kato] 2011-08-16 22:03:28 PDT
Created attachment 553679 [details] [diff] [review]
fix
Comment 4 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-08-17 04:40:02 PDT
Comment on attachment 553679 [details] [diff] [review]
fix

This looks fine, but why isn't the 32 bit build affected?
Comment 5 Makoto Kato [:m_kato] 2011-08-17 06:21:11 PDT
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #4)
> Comment on attachment 553679 [details] [diff] [review]
> fix
> 
> This looks fine, but why isn't the 32 bit build affected?

If we use --disable-shared-js on Win32, same issue occurs.
Comment 6 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-08-17 06:24:30 PDT
(In reply to Makoto Kato from comment #5)
> (In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #4)
> > Comment on attachment 553679 [details] [diff] [review]
> > fix
> > 
> > This looks fine, but why isn't the 32 bit build affected?
> 
> If we use --disable-shared-js on Win32, same issue occurs.

Ah, disable-shared, not enable-shared ... that would explain it.
Comment 7 Armen Zambrano [:armenzg] (EDT/UTC-4) 2011-08-17 11:20:45 PDT
Is this ready to check-in?
Comment 8 Makoto Kato [:m_kato] 2011-08-17 17:38:02 PDT
http://hg.mozilla.org/mozilla-central/rev/7054f0e3e70e

Note You need to log in before you can comment on or make changes to this bug.