The default bug view has changed. See this FAQ.
Bug 673759 (namedspaceOverriding)

[MathML3] Remove namedspace value overriding

RESOLVED FIXED in mozilla15

Status

()

Core
MathML
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: fredw, Assigned: fredw)

Tracking

(Blocks: 1 bug, {dev-doc-complete})

Trunk
mozilla15
dev-doc-complete
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 8 obsolete attachments)

3.34 KB, patch
karlt
: review+
emorley
: checkin+
Details | Diff | Splinter Review
5.49 KB, patch
karlt
: review+
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
The REC says:

"MathML2 allowed the binding of namedspaces to new values. It appears that this capability was never implemented, and is now deprecated; namedspaces are now considered constants. For backwards compatibility, the following attributes are accepted on the mstyle element, but are expected to have no effect."

We implement namedspace value overriding in nsMathMLFrame::ParseNamedSpaceValue. Removing this will allow to get rid of many almost never used nsGkAtoms for namespaces. This will also simplify the parsing code: we could move the parsing for namespaces into nsMathMLElement::ParseNumericValue (and add a flag PARSE_ALLOW_NAMEDSPACE).
(Assignee)

Updated

6 years ago
Assignee: nobody → hage.jonathan
Status: NEW → ASSIGNED

Comment 1

6 years ago
Created attachment 549072 [details] [diff] [review]
Unification of nsMathMLFrame::ParseNamedSpaceValue into nsMathMLElement::ParseNumericValue + Removing of namedspace value overriding

Comment 2

6 years ago
Created attachment 549073 [details] [diff] [review]
Reftest for positive namedspaces

Comment 3

6 years ago
Created attachment 549088 [details] [diff] [review]
Moving nsMathMLFrame::ParseNamedSpaceValue into nsMathMLElement::ParseNumericValue + Removing of namedspace value overriding

Comment 4

6 years ago
Created attachment 550018 [details] [diff] [review]
Moving nsMathMLFrame::ParseNamedSpaceValue into nsMathMLElement::ParseNumericValue + Removing of namedspace value overriding
Attachment #549072 - Attachment is obsolete: true
Attachment #549088 - Attachment is obsolete: true

Comment 5

6 years ago
Created attachment 550043 [details] [diff] [review]
Moving nsMathMLFrame::ParseNamedSpaceValue into nsMathMLElement::ParseNumericValue + Removing of namedspace value overriding
Attachment #550018 - Attachment is obsolete: true
(Assignee)

Comment 6

6 years ago
(In reply to comment #5)
> Created attachment 550043 [details] [diff] [review] [diff] [details] [review]
> Moving nsMathMLFrame::ParseNamedSpaceValue into
> nsMathMLElement::ParseNumericValue + Removing of namedspace value overriding

Compilation fails with this patch:

/src-obj/mozilla/src/content/base/src/nsTreeSanitizer.cpp:952: error: ‘negativemediummathspace_’ is not a member of ‘nsGkAtoms’
...

The nsGkAtoms for spaces should be removed everywhere.
(Assignee)

Updated

6 years ago
Blocks: 677036

Comment 7

6 years ago
Created attachment 551404 [details] [diff] [review]
Moving nsMathMLFrame::ParseNamedSpaceValue into nsMathMLElement::ParseNumericValue + Removing of namedspace value overriding v2
Attachment #550043 - Attachment is obsolete: true

Comment 8

6 years ago
Created attachment 551407 [details] [diff] [review]
no flags 	Details | Diff | Splinter Review Moving nsMathMLFrame::ParseNamedSpaceValue into nsMathMLElement::ParseNumericValue + Removing of namedspace value overriding (30.16 KB, patch) 2011-07-28 06
Attachment #551404 - Attachment is obsolete: true

Comment 9

6 years ago
Created attachment 551414 [details] [diff] [review]
Moving nsMathMLFrame::ParseNamedSpaceValue into nsMathMLElement::ParseNumericValue + Removing of namedspace value overriding v2
Attachment #551407 - Attachment is obsolete: true
(Assignee)

Comment 10

6 years ago
Comment on attachment 549073 [details] [diff] [review]
Reftest for positive namedspaces

We can probably already take this reftest.
Attachment #549073 - Flags: review?(karlt)
Attachment #549073 - Flags: review?(karlt) → review+
(Assignee)

Comment 11

6 years ago
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=74d9def9c9de
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
Whiteboard: [good first bug] → [good first bug][please push attachment 549073]
I'm presuming this needs to be left open for the other patch? Should a review be set on that patch?

https://hg.mozilla.org/integration/mozilla-inbound/rev/f5ce0b70c2e1
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [good first bug][please push attachment 549073] → [good first bug] [leave open for remaining patch]
Target Milestone: --- → mozilla9
Attachment #549073 - Flags: checkin+
Comment on attachment 549073 [details] [diff] [review]
Reftest for positive namedspaces

https://hg.mozilla.org/mozilla-central/rev/f5ce0b70c2e1
Remaining patch isn't going to make it for mozilla9, so removing target milestone for now.
Target Milestone: mozilla9 → ---
(Assignee)

Updated

5 years ago
Assignee: hage.jonathan → fred.wang
(Assignee)

Updated

5 years ago
Alias: namedspaceOverriding
Depends on: 696647
(Assignee)

Comment 15

5 years ago
Created attachment 586105 [details] [diff] [review]
Patch V3 - part 1
Attachment #551414 - Attachment is obsolete: true
(Assignee)

Comment 16

5 years ago
Created attachment 586107 [details] [diff] [review]
Patch V3 - part 2

Part 2, removing the corresponding MathML Atoms. To apply over patch from bug 696647.

I'm not sure this patch is good idea, though. Bug 324472 comment 5 says that atoms are needed for clipboard operations.
(Assignee)

Comment 17

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=bf7895f8e2fb
(Assignee)

Comment 18

5 years ago
Comment on attachment 586105 [details] [diff] [review]
Patch V3 - part 1

Note: I have not changed the flags passed to ParseNumericValue, as I expect this job to be done in bug 411227.
Attachment #586105 - Flags: review?(karlt)
(Assignee)

Updated

5 years ago
Attachment #586105 - Flags: review?(karlt)
(Assignee)

Updated

5 years ago
No longer blocks: 677036
Depends on: 677036
(Assignee)

Updated

5 years ago
Attachment #586107 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #586105 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #586107 - Attachment is obsolete: false
(Assignee)

Updated

5 years ago
Whiteboard: [good first bug] [leave open for remaining patch] → [leave open for remaining patch]
(Assignee)

Updated

5 years ago
Keywords: helpwanted
(Assignee)

Comment 19

5 years ago
Comment on attachment 586107 [details] [diff] [review]
Patch V3 - part 2

So now bug 677036 is fixed, it should not be possible to override namedspace. Karl, do you think we should take attachment 586107 [details] [diff] [review]? Bug 324472 comment 5 indicates that atoms are needed for clipboard operations. However, I don't think people have ever used namedspace overriding, so that should not be a problem?
Attachment #586107 - Flags: review?(karlt)
Comment on attachment 586107 [details] [diff] [review]
Patch V3 - part 2

Yes, makes sense to remove these now, thanks.
Attachment #586107 - Flags: review?(karlt) → review+
(Assignee)

Comment 21

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=5adfc5ff68c7

I'm not sure how the build results can be red (with empty summaries) but the tests are executed and seem successful.
(Assignee)

Updated

5 years ago
No longer depends on: 677036
(Assignee)

Updated

5 years ago
Depends on: 677036
(Assignee)

Comment 22

5 years ago
(In reply to Frédéric Wang (:fredw) from comment #21)
> https://tbpl.mozilla.org/?tree=Try&rev=5adfc5ff68c7
> 
> I'm not sure how the build results can be red (with empty summaries) but the
> tests are executed and seem successful.

Karl, do you have any idea about this problem? I can build opt/debug builds without problems with this patch applied. I tried the patch twice on the Try server and always got this build results in red, with empty summaries.
I don't know what happened there but some others had similar problems
e.g. https://tbpl.mozilla.org/?tree=Try&rev=be00392bbc1f

I'd try pulling and rebasing against the latest known good changeset.
(Assignee)

Comment 24

5 years ago
OK, that looks better:
https://tbpl.mozilla.org/?tree=Try&rev=3dc56ac6f8c3
Keywords: checkin-needed
Whiteboard: [leave open for remaining patch]
https://hg.mozilla.org/integration/mozilla-inbound/rev/a048bf8506f7
Keywords: checkin-needed
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/a048bf8506f7
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Keywords: dev-doc-needed
Updated docs:
https://developer.mozilla.org/en/MathML/Attributes/Values#Constants
https://developer.mozilla.org/en/Firefox_15_for_developers#MathML
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.