Last Comment Bug 696647 - Remove unused (invalid) MathML atoms
: Remove unused (invalid) MathML atoms
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: MathML (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla12
Assigned To: Florian Scholz [:fscholz] (MDN)
:
Mentors:
Depends on:
Blocks: namedspaceOverriding
  Show dependency treegraph
 
Reported: 2011-10-23 09:25 PDT by Florian Scholz [:fscholz] (MDN)
Modified: 2012-01-11 18:20 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (3.98 KB, patch)
2012-01-05 08:11 PST, Florian Scholz [:fscholz] (MDN)
karlt: review+
Details | Diff | Splinter Review

Description Florian Scholz [:fscholz] (MDN) 2011-10-23 09:25:30 PDT
(Follow-up from bug 324472 comment 10)

Some MathML atoms in nsGkAtomList.h and nsTreeSanitizer.cpp seem to be unused (and wrongly mentioned in the MathML3 element index). We should probably remove them.

To be under consideration for now:

[1] malign: See http://lists.w3.org/Archives/Public/www-math/2011Sep/0001.html

[2] malignscope
"*Future* versions of MathML may provide an malignscope element that allows an alignment scope to be created around any MathML element [...]" (http://www.w3.org/TR/MathML3/chapter3.html#id.3.5.5.1) That is, malignscope isn't specified yet?

[3] mfraction
"[...] the non-MathML element mfraction (presumably in place of the MathML element mfrac) [...]" (http://www.w3.org/TR/MathML3/chapter3.html#id.3.3.5.3)
So "mfraction" does not exist and is just a sample for wrong markup ?

[4] monospaced 
The MathML3 spec index links to http://www.w3.org/TR/MathML3/chapter2.html#fund.attval but there is no "monospaced" element/attribute ?!?
Comment 1 Frédéric Wang (:fredw) 2011-12-11 06:48:02 PST
It would be a good idea to report these errors or questions to the MathML WG.
Comment 2 Florian Scholz [:fscholz] (MDN) 2012-01-03 03:52:08 PST
http://lists.w3.org/Archives/Public/www-math/2011Dec/0003.html
http://lists.w3.org/Archives/Public/www-math/2012Jan/0000.html

I can prepare a patch for removing these bits.
Comment 3 Florian Scholz [:fscholz] (MDN) 2012-01-05 08:11:08 PST
Created attachment 586090 [details] [diff] [review]
Patch
Comment 4 Frédéric Wang (:fredw) 2012-01-10 05:28:52 PST
I tested this patch there:
https://tbpl.mozilla.org/?tree=Try&rev=bf7895f8e2fb
Comment 6 Ed Morley [:emorley] 2012-01-11 18:20:06 PST
https://hg.mozilla.org/mozilla-central/rev/37ede8ee0d0e

Note You need to log in before you can comment on or make changes to this bug.