Closed Bug 673919 Opened 9 years ago Closed 6 years ago

Remove routeEvent, enableExternalCapture and disableExternalCapture

Categories

(Core :: DOM: Events, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25
Tracking Status
firefox24 + fixed
firefox25 + fixed

People

(Reporter: bruant.d, Assigned: emk)

References

Details

(Keywords: addon-compat, dev-doc-complete, site-compat, Whiteboard: [qa-])

Attachments

(3 files, 3 obsolete files)

These functions have been obseleted in Gecko 1.9 (Firefox 3) https://developer.mozilla.org/en/Gecko_1.9_Changes_affecting_websites#A_few_other_old_event_APIs_are_no_longer_supported


I have discovered them today randomly by traversing the global object on a webpage.
After research, these functions are not seems standard from what I've seen. I've never heard of anyone using them in code.
Bug 132132 asks for removal and is solved as duplicate of Bug 330494. Yet, I still see these properties on the global object in the webconsole and Firebug
> and is solved as duplicate of Bug 330494

Which it's not.  The guy who did that confused deprecation and removal.

Olli, can we remove these now?  I seem to recall some sites using them, but maybe that was a while ago?
Duplicate of this bug: 132132
I intend to remove these from Blink.
OS: Linux → All
Hardware: x86 → All
Version: 5 Branch → Trunk
Green on try: https://tbpl.mozilla.org/?tree=Try&rev=671d217429b2
Assignee: nobody → VYV03354
Attachment #747175 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #747619 - Flags: review?(bugs)
Comment on attachment 747619 [details] [diff] [review]
Remove captureEvents, releaseEvents, and routeEvent

The crashtest is odd, but ok.

This should land early in a cycle, so could you land this after the next merge, which
happens next week.
Attachment #747619 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/2aa62db58f24
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
(In reply to Kohei Yoshino from comment #10)
> Updated:
> https://developer.mozilla.org/en-US/docs/Gecko_1.9_Changes_affecting_websites
> https://developer.mozilla.org/en-US/docs/Web/API/document
> https://developer.mozilla.org/en-US/docs/Web/API/window
> https://developer.mozilla.org/en-US/docs/Web/API/window.captureEvents
> https://developer.mozilla.org/en-US/docs/Web/API/window.releaseEvents
> https://developer.mozilla.org/en-US/docs/Web/API/window.routeEvent
> 
> Added:
> https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_24
Thanks for the doc! It all looks good to me.

> Bug 330494 deprecated preventBubble and preventCapture too but these are
> still implemented. Is this intended?
I wish I had noticed these when reporting this bug to add them to the list of things to remove :-/
Filed bug 874003 for this.
Unfortunately we had to add them back to Chrome. There is a lot of code out there that starts with:

if (!IE) {
  document.captureEvents();
}

Another data point is that IE11 (which does not identify as IE) had to add it as well.

Sigh.
Argh.

Sounds like we need to back out the change and HTML spec needs to be updated.

emk, could you back out the change?
Flags: needinfo?(VYV03354)
Switching the doc back to dev-doc-needed to not forget to update the doc (or not) once the decision is taken :-(
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd49d8389a9b
I couldn't simply backout the changeset because nsIDOMJSWindow and nsIDOMHTMLDocument were changed after this bug.
Also this bug contains a string change. Can I land this patch on Aurora?
Flags: needinfo?(VYV03354)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Upload the patch for Aurora and ask for approval.
Attached patch Backout patch for aurora (obsolete) — Splinter Review
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 673919
User impact if declined: A lot of Websites will be broken, according to a report from Google
Testing completed (on m-c, etc.): waiting for merge on m-i
Risk to taking this patch (and alternatives if risky): low, backout.
String or IDL/UUID changes made by this patch: uuid will be reverted but removed strings will be re-added.
Attachment #784042 - Flags: approval-mozilla-aurora?
uuid change is a simple backout on aurora.
Try removing routeEvent() again. And I bet enableExternalCapture() and disableExternalCapture() are not needed.
Attachment #784070 - Flags: review?(bugs)
Attachment #784070 - Flags: review?(bugs) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/8103ed66ceef
Target Milestone: mozilla24 → mozilla25
[Approval Request Comment]
See comment #18, modulo:
String or IDL/UUID changes made by this patch: uuid will be reverted. No string change.

Only one of this patch or attachment 784042 [details] [diff] [review] needs an approval.
Attachment #784406 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/8103ed66ceef
Status: REOPENED → RESOLVED
Closed: 7 years ago6 years ago
Resolution: --- → FIXED
Summary: Remove releaseEvents, captureEvents, routeEvent → Remove releaseEvents, enableExternalCapture, disableExternalCapture
Comment on attachment 784406 [details] [diff] [review]
Backout patch without reverting string change

PLease make sure the UUID change is backed out as well.
Attachment #784406 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 784042 [details] [diff] [review]
Backout patch for aurora

Approved the alternate patch without the  removal of string's
Attachment #784042 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
Attachment #784042 - Attachment is obsolete: true
Sorry, I have no time to watch the tree right now.
Keywords: checkin-needed
Attachment #784406 - Flags: checkin?
Already reverted (and relanded without captureEvents and releaseEvents removal) on Nightly.
Whiteboard: [land the approved patch to aurora]
Attachment #784406 - Flags: checkin? → checkin+
Marking WONTFIX and clearing the keywords to avoid confusion, as the patches have been backed out.
Resolution: FIXED → WONTFIX
Actually this bug has been morphed to a bug removing releaseEvents, enableExternalCapture, disableExternalCapture (see the Summary change).
Maybe I should have filed a new bug. Sorry for the confusion.
Resolution: WONTFIX → FIXED
So the documentation should be updated again.
Oh, oh...

(In reply to Masatoshi Kimura [:emk] from comment #29)
> https://hg.mozilla.org/releases/mozilla-aurora/rev/4ea223de889c

As per this changeset,
* Still available: captureEvents, releaseEvents
* Removed: routeEvent, enableExternalCapture, disableExternalCapture
so the summary should be corrected here.
Summary: Remove releaseEvents, enableExternalCapture, disableExternalCapture → Remove routeEvent, enableExternalCapture and disableExternalCapture
> Recently Google Chrome (the Blink rendering engine) also removed the support for those methods.

This sentence should be removed because Google Chrome reverted the removal of captureEvents and releaseEvents, and it have never supported the rest from the start.
(In reply to Masatoshi Kimura [:emk] from comment #35)
> > Recently Google Chrome (the Blink rendering engine) also removed the support for those methods.
> 
> This sentence should be removed because Google Chrome reverted the removal
> of captureEvents and releaseEvents, and it have never supported the rest
> from the start.

Removed the incorrect sentence. Thanks!
Assuming no QA needed here.
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.