674013 - extensions defaults win over system-wide preferences and user.js

Status: RESOLVED INCOMPLETE

(Core :: Preferences: Backend, defect)

Description

[Jeff Hammel]

if in this user.js I specify a preference from the extension's
defaults/preferences/prefs.js directory, then the retrieved preference
value is always the value from defaults/preferences/prefs.js and not
the value from user.js.

Comment 1

[Mark Banner (:standard8)]

I've seen a similar report to this against Thunderbird I believe, unfortunately I can't find it at the moment.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Dave, is this a known issue for Firefox?

Comment 3

[Dave Townsend [:mossop]]

It's not something I've come across before, this should probably be moved to the preferences component.

Comment 4

[Dave Townsend [:mossop]]

It's probably just a problem with us loading extension defaults later than user.js, this may even be a regression since Firefox 4 as we meddled with the pref loading there.

Comment 5

[Jeff Hammel]

We need to be careful, though, in relegating this to Core. While I would prefer to fix it there, the Mozmill issue needs to be addressed in any case.

Comment 6

[Dave Townsend [:mossop]]

Feel free to move it back and file a new bug in core or vice-versa then.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Jeff, I don't think that we have a Mozmill issue here. Or I'm not sure about which specific issue you are talking about.

Marc, can you please run your example again with Firefox 3.6.x? Would be good to know if it is a regression between 3.6 and 4.0.

Comment 8

[Marc-Aurèle DARCHE]

(In reply to comment #7)
> Marc, can you please run your example again with Firefox 3.6.x? Would be
> good to know if it is a regression between 3.6 and 4.0.

After testing, I confirm that this is a regression between Firefox 3.6 and Firefox 4.0.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Marc, would you even have time to nail down the regression range to a specific date? That would be great.

Comment 10

[Marc-Aurèle DARCHE]

(In reply to comment #9)
> Marc, would you even have time to nail down the regression range to a
> specific date? That would be great.

Sorry, I cannot say more than between the release of Firefox 3.6 (January 21, 2010) and Firefox 4.0 (March 22, 2011) :-\
I even have had a hard time finding a 4.0 release on http://releases.mozilla.org/pub/mozilla.org/firefox/releases/ : there isn't any at the moment, so I tested with http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/4.0.1-candidates/build1/

Comment 11

[Dave Townsend [:mossop]]

Almost certainly a regression from bug 533038

Comment 12

[Michael Wu [:mwu]]

(In reply to comment #11)
> Almost certainly a regression from bug 533038

Bug 576492 put extension pref loading after user.js loading (which occurs during profile-do-change).

http://hg.mozilla.org/mozilla-central/rev/a844e2a8c654

Comment 13

[Marc-Aurèle DARCHE]

So, please, what's to do next with this bug report? I'm a bit at a loss.

Has a fix arrived through other commits? Should I just try a nightly and report if it's actually fixed?

Thank you!

Comment 14

[Michael Wu [:mwu]]

Not fixed. And there's nobody assigned to it.

I'll take it. Should be easy enough.

Comment 17

[[:Aleksej]]

Removing "regressionwindow-wanted" because of comment 12.

Comment 18

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Michael Wu [:mwu] from comment #14)
> I'll take it. Should be easy enough.

Michael, do you have any news about the state of the patch for this bug? Can we get it fixed? I ask because we a blocked with some of our Mozmill tests for add-ons due to this behavior. Thanks.

Comment 19

[Josh Triplett]

I'm observing this problem with Firefox 11, and it prevents me from configuring default system-wide preferences for extensions.

Comment 20

[Nicholas Nethercote [inactive]]

Legacy extensions are no longer supported, and bug 1413413 removed the ability for extensions to have their own prefs file. So I believe this is no longer relevant.