Last Comment Bug 674014 - Remove "check whether mmap() sees write()s"
: Remove "check whether mmap() sees write()s"
Status: RESOLVED FIXED
[good first bug][inbound]
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla9
Assigned To: Marco Castelluccio [:marco]
:
Mentors:
Depends on:
Blocks: 679352
  Show dependency treegraph
 
Reported: 2011-07-25 12:29 PDT by Mike Hommey [:glandium]
Modified: 2011-08-19 03:07 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (10.89 KB, patch)
2011-08-15 15:19 PDT, Marco Castelluccio [:marco]
mh+mozilla: review+
Details | Diff | Splinter Review
Patch v2 (14.44 KB, patch)
2011-08-17 03:55 PDT, Marco Castelluccio [:marco]
mh+mozilla: review+
Details | Diff | Splinter Review

Description Mike Hommey [:glandium] 2011-07-25 12:29:41 PDT
This is only used in modules/libreg/src/mmapio.c. But it's not even built, cf.
http://mxr.mozilla.org/mozilla-central/source/modules/libreg/src/Makefile.in#71

The file and these comments could be removed at the same time.
Comment 1 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-07-25 12:32:41 PDT
I think all of libreg is dead code, if we ever got around to removing the netscape profile migrator.

If we didn't, we should remove the migrator and then remove libreg.
Comment 2 Mike Hommey [:glandium] 2011-07-25 13:50:26 PDT
(In reply to comment #1)
> I think all of libreg is dead code, if we ever got around to removing the
> netscape profile migrator.
> 
> If we didn't, we should remove the migrator and then remove libreg.

We didn't. http://mxr.mozilla.org/mozilla-central/source/browser/components/migration/src/nsNetscapeProfileMigratorBase.cpp
Comment 3 Marco Castelluccio [:marco] 2011-08-15 15:19:38 PDT
Created attachment 553281 [details] [diff] [review]
Patch
Comment 4 Mike Hommey [:glandium] 2011-08-17 00:09:22 PDT
Comment on attachment 553281 [details] [diff] [review]
Patch

Review of attachment 553281 [details] [diff] [review]:
-----------------------------------------------------------------

r+ on this part. This however doesn't remove the configure.in test from the bug subject.
Comment 5 Marco Castelluccio [:marco] 2011-08-17 03:55:35 PDT
Created attachment 553724 [details] [diff] [review]
Patch v2
Comment 7 Marco Bonardo [::mak] 2011-08-19 03:07:30 PDT
http://hg.mozilla.org/mozilla-central/rev/a67e4bd575b4

Note You need to log in before you can comment on or make changes to this bug.