674014 - Remove "check whether mmap() sees write()s"

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

This is only used in modules/libreg/src/mmapio.c. But it's not even built, cf.
http://mxr.mozilla.org/mozilla-central/source/modules/libreg/src/Makefile.in#71

The file and these comments could be removed at the same time.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I think all of libreg is dead code, if we ever got around to removing the netscape profile migrator.

If we didn't, we should remove the migrator and then remove libreg.

Comment 2

[Mike Hommey [:glandium]]

(In reply to comment #1)
> I think all of libreg is dead code, if we ever got around to removing the
> netscape profile migrator.
> 
> If we didn't, we should remove the migrator and then remove libreg.

We didn't. http://mxr.mozilla.org/mozilla-central/source/browser/components/migration/src/nsNetscapeProfileMigratorBase.cpp

Comment 3

[Marco Castelluccio [:marco]]

Attachment: Patch

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 553281 [details] [diff] [review]
Patch

Review of attachment 553281 [details] [diff] [review]:
-----------------------------------------------------------------

r+ on this part. This however doesn't remove the configure.in test from the bug subject.

Comment 5

[Marco Castelluccio [:marco]]

Attachment: Patch v2

Comment 6

[Marco Bonardo [:mak]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/a67e4bd575b4

Comment 7

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/a67e4bd575b4