Closed
Bug 674014
Opened 13 years ago
Closed 13 years ago
Remove "check whether mmap() sees write()s"
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla9
People
(Reporter: glandium, Assigned: marco)
References
Details
(Whiteboard: [good first bug][inbound])
Attachments
(1 file, 1 obsolete file)
14.44 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
This is only used in modules/libreg/src/mmapio.c. But it's not even built, cf. http://mxr.mozilla.org/mozilla-central/source/modules/libreg/src/Makefile.in#71 The file and these comments could be removed at the same time.
I think all of libreg is dead code, if we ever got around to removing the netscape profile migrator. If we didn't, we should remove the migrator and then remove libreg.
Reporter | ||
Comment 2•13 years ago
|
||
(In reply to comment #1) > I think all of libreg is dead code, if we ever got around to removing the > netscape profile migrator. > > If we didn't, we should remove the migrator and then remove libreg. We didn't. http://mxr.mozilla.org/mozilla-central/source/browser/components/migration/src/nsNetscapeProfileMigratorBase.cpp
Whiteboard: [good first bug]
Reporter | ||
Updated•13 years ago
|
Summary: Remove "whether mmap() sees write()s" → Remove "check whether mmap() sees write()s"
Assignee | ||
Comment 3•13 years ago
|
||
Attachment #553281 -
Flags: review?(mh+mozilla)
Reporter | ||
Comment 4•13 years ago
|
||
Comment on attachment 553281 [details] [diff] [review] Patch Review of attachment 553281 [details] [diff] [review]: ----------------------------------------------------------------- r+ on this part. This however doesn't remove the configure.in test from the bug subject.
Attachment #553281 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → mar.castelluccio
Assignee | ||
Comment 5•13 years ago
|
||
Attachment #553281 -
Attachment is obsolete: true
Attachment #553724 -
Flags: review?(mh+mozilla)
Reporter | ||
Updated•13 years ago
|
Attachment #553724 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 6•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/a67e4bd575b4
Keywords: checkin-needed
Whiteboard: [good first bug] → [good first bug][inbound]
Comment 7•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/a67e4bd575b4
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•