Closed Bug 674014 Opened 8 years ago Closed 8 years ago

Remove "check whether mmap() sees write()s"

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla9

People

(Reporter: glandium, Assigned: marco)

References

Details

(Whiteboard: [good first bug][inbound])

Attachments

(1 file, 1 obsolete file)

This is only used in modules/libreg/src/mmapio.c. But it's not even built, cf.
http://mxr.mozilla.org/mozilla-central/source/modules/libreg/src/Makefile.in#71

The file and these comments could be removed at the same time.
I think all of libreg is dead code, if we ever got around to removing the netscape profile migrator.

If we didn't, we should remove the migrator and then remove libreg.
(In reply to comment #1)
> I think all of libreg is dead code, if we ever got around to removing the
> netscape profile migrator.
> 
> If we didn't, we should remove the migrator and then remove libreg.

We didn't. http://mxr.mozilla.org/mozilla-central/source/browser/components/migration/src/nsNetscapeProfileMigratorBase.cpp
Whiteboard: [good first bug]
Summary: Remove "whether mmap() sees write()s" → Remove "check whether mmap() sees write()s"
Attached patch Patch (obsolete) — Splinter Review
Attachment #553281 - Flags: review?(mh+mozilla)
Comment on attachment 553281 [details] [diff] [review]
Patch

Review of attachment 553281 [details] [diff] [review]:
-----------------------------------------------------------------

r+ on this part. This however doesn't remove the configure.in test from the bug subject.
Attachment #553281 - Flags: review?(mh+mozilla) → review+
Assignee: nobody → mar.castelluccio
Attached patch Patch v2Splinter Review
Attachment #553281 - Attachment is obsolete: true
Attachment #553724 - Flags: review?(mh+mozilla)
Attachment #553724 - Flags: review?(mh+mozilla) → review+
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/a67e4bd575b4
Keywords: checkin-needed
Whiteboard: [good first bug] → [good first bug][inbound]
Blocks: 679352
http://hg.mozilla.org/mozilla-central/rev/a67e4bd575b4
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.