Remove "check whether mmap() sees write()s"

RESOLVED FIXED in mozilla9

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: glandium, Assigned: marco)

Tracking

Trunk
mozilla9
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][inbound])

Attachments

(1 attachment, 1 obsolete attachment)

This is only used in modules/libreg/src/mmapio.c. But it's not even built, cf.
http://mxr.mozilla.org/mozilla-central/source/modules/libreg/src/Makefile.in#71

The file and these comments could be removed at the same time.
I think all of libreg is dead code, if we ever got around to removing the netscape profile migrator.

If we didn't, we should remove the migrator and then remove libreg.
(In reply to comment #1)
> I think all of libreg is dead code, if we ever got around to removing the
> netscape profile migrator.
> 
> If we didn't, we should remove the migrator and then remove libreg.

We didn't. http://mxr.mozilla.org/mozilla-central/source/browser/components/migration/src/nsNetscapeProfileMigratorBase.cpp
Whiteboard: [good first bug]
Summary: Remove "whether mmap() sees write()s" → Remove "check whether mmap() sees write()s"
(Assignee)

Comment 3

6 years ago
Created attachment 553281 [details] [diff] [review]
Patch
Attachment #553281 - Flags: review?(mh+mozilla)
Comment on attachment 553281 [details] [diff] [review]
Patch

Review of attachment 553281 [details] [diff] [review]:
-----------------------------------------------------------------

r+ on this part. This however doesn't remove the configure.in test from the bug subject.
Attachment #553281 - Flags: review?(mh+mozilla) → review+
(Assignee)

Updated

6 years ago
Assignee: nobody → mar.castelluccio
(Assignee)

Comment 5

6 years ago
Created attachment 553724 [details] [diff] [review]
Patch v2
Attachment #553281 - Attachment is obsolete: true
Attachment #553724 - Flags: review?(mh+mozilla)
Attachment #553724 - Flags: review?(mh+mozilla) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/a67e4bd575b4
Keywords: checkin-needed
Whiteboard: [good first bug] → [good first bug][inbound]
(Assignee)

Updated

6 years ago
Blocks: 679352
http://hg.mozilla.org/mozilla-central/rev/a67e4bd575b4
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.