674310 - Automatic Find as you type broken

Status: RESOLVED FIXED

(SeaMonkey :: Find In Page, defect)

Description

[Hans]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0a1) Gecko/20110726 Firefox/8.0a1 SeaMonkey/2.5a1
Build ID: 20110726003039

Steps to reproduce:

Type text for a Link as usual for Find as you type.


Actual results:

Nothing.


Expected results:

Link should be selected.

(starting Find as you type with ' character still works), through.

This was broken the last 2-3 days, I think.

Build identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0a1) Gecko/20110726 Firefox/8.0a1 SeaMonkey/2.5a1

Comment 1

[Philip Chee]

Error: invalid 'instanceof' operand Components.interfaces.nsIDOMHTMLIsIndexElement
Source file: jar:file:///C:/T1/hg/objdir-sm/mozilla/dist/seamonkey/omni.jar!/components/nsTypeAheadFind.js
Line: 193

Ms2ger said he killed nsIDOMHTMLIsIndexElement

<Ms2ger> I'd just remove that line, it's been dead since Gk2

Comment 2

[Philip Chee]

<Ms2ger> I'm surprised you don't check input

Comment 3

[[e-mail]]

(In reply to comment #2)
> <Ms2ger> I'm surprised you don't check input
Why am I not surprised that Ms2ger doesn't check comm-central?

Anyway, we do check input, it's 6 lines further down.

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch [Checkin: comment 5]

nsIDOMHTMLIsIndexElement was removed in m-c changeset 0f00661af740 / bug 666665. Has not propagated to Aurora yet, so landing on c-c should do.

This is a brain-dead removal action, so IMO not a good GFB candidate. Let's just fix it right now.

Comment 5

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 548822 [details] [diff] [review]
patch [Checkin: comment 5]

http://hg.mozilla.org/comm-central/rev/d76b160f0737

Comment 6

[[e-mail]]

Anyone want to fix findbar.xml which contains our last reference?

Comment 7

[Philip Chee]

> Anyone want to fix findbar.xml which contains our last reference?
Patch in bug 687317. Who wants to steal the review?