Last Comment Bug 674618 - ././js-confdefs.h:110:1: warning: "__STDC_LIMIT_MACROS" redefined
: ././js-confdefs.h:110:1: warning: "__STDC_LIMIT_MACROS" redefined
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Other Branch
: All All
: -- normal (vote)
: mozilla8
Assigned To: Jason Orendorff [:jorendorff]
:
Mentors:
Depends on:
Blocks: 673556
  Show dependency treegraph
 
Reported: 2011-07-27 11:48 PDT by Jason Orendorff [:jorendorff]
Modified: 2011-07-29 03:10 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1 (820 bytes, patch)
2011-07-27 11:54 PDT, Jason Orendorff [:jorendorff]
khuey: review+
Details | Diff | Review
v2 - cover all of js/src at least (1.67 KB, patch)
2011-07-28 13:05 PDT, Jason Orendorff [:jorendorff]
jimb: review+
Details | Diff | Review

Description Jason Orendorff [:jorendorff] 2011-07-27 11:48:01 PDT
Now we define it in confdefs.h, so we don't need to also have a -D flag in js/src/Makefile.in. Patching.
Comment 1 Jason Orendorff [:jorendorff] 2011-07-27 11:54:32 PDT
Created attachment 548854 [details] [diff] [review]
v1

Here's my opening salvo, anyway. We're now globally doing the thing that this comment I'm removing calls "obscure and fragile". Maybe instead we should do the non-obscure, non-fragile thing in root as well as js/src? I dunno.

I know nothing about js-config.h/jsautocfg.h/js-confdefs.h/configure.in/Makefile.in, so the responsibility to exercise good taste is entirely on the reviewer here. ;-)
Comment 2 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-07-27 11:56:12 PDT
http://mxr.mozilla.org/mozilla-central/search?string=STDC_LIMIT_MACROS
Comment 3 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-07-28 13:02:26 PDT
Comment on attachment 548854 [details] [diff] [review]
v1

We should fix this other locations though ...
Comment 4 Jason Orendorff [:jorendorff] 2011-07-28 13:05:36 PDT
Created attachment 549204 [details] [diff] [review]
v2 - cover all of js/src at least
Comment 5 Jim Blandy :jimb 2011-07-28 13:53:10 PDT
Comment on attachment 549204 [details] [diff] [review]
v2 - cover all of js/src at least

Review of attachment 549204 [details] [diff] [review]:
-----------------------------------------------------------------
Comment 6 Jason Orendorff [:jorendorff] 2011-07-28 14:58:16 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/dbe9a61e0b2c
Comment 7 Marco Bonardo [::mak] 2011-07-29 03:10:51 PDT
http://hg.mozilla.org/mozilla-central/rev/dbe9a61e0b2c

Note You need to log in before you can comment on or make changes to this bug.