Note: There are a few cases of duplicates in user autocompletion which are being worked on.

././js-confdefs.h:110:1: warning: "__STDC_LIMIT_MACROS" redefined

RESOLVED FIXED in mozilla8

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jorendorff, Assigned: jorendorff)

Tracking

Other Branch
mozilla8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Now we define it in confdefs.h, so we don't need to also have a -D flag in js/src/Makefile.in. Patching.
(Assignee)

Comment 1

6 years ago
Created attachment 548854 [details] [diff] [review]
v1

Here's my opening salvo, anyway. We're now globally doing the thing that this comment I'm removing calls "obscure and fragile". Maybe instead we should do the non-obscure, non-fragile thing in root as well as js/src? I dunno.

I know nothing about js-config.h/jsautocfg.h/js-confdefs.h/configure.in/Makefile.in, so the responsibility to exercise good taste is entirely on the reviewer here. ;-)
Assignee: general → jorendorff
Attachment #548854 - Flags: review?(ted.mielczarek)
http://mxr.mozilla.org/mozilla-central/search?string=STDC_LIMIT_MACROS
Comment on attachment 548854 [details] [diff] [review]
v1

We should fix this other locations though ...
Attachment #548854 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 4

6 years ago
Created attachment 549204 [details] [diff] [review]
v2 - cover all of js/src at least
Attachment #548854 - Attachment is obsolete: true
Attachment #549204 - Flags: review?(jimb)

Comment 5

6 years ago
Comment on attachment 549204 [details] [diff] [review]
v2 - cover all of js/src at least

Review of attachment 549204 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #549204 - Flags: review?(jimb) → review+
(Assignee)

Comment 6

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/dbe9a61e0b2c
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/dbe9a61e0b2c
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.