Closed
Bug 674618
Opened 14 years ago
Closed 14 years ago
././js-confdefs.h:110:1: warning: "__STDC_LIMIT_MACROS" redefined
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: jorendorff, Assigned: jorendorff)
References
Details
(Whiteboard: [inbound])
Attachments
(1 file, 1 obsolete file)
|
1.67 KB,
patch
|
jimb
:
review+
|
Details | Diff | Splinter Review |
Now we define it in confdefs.h, so we don't need to also have a -D flag in js/src/Makefile.in. Patching.
|
Assignee | |
Comment 1•14 years ago
|
||
Here's my opening salvo, anyway. We're now globally doing the thing that this comment I'm removing calls "obscure and fragile". Maybe instead we should do the non-obscure, non-fragile thing in root as well as js/src? I dunno.
I know nothing about js-config.h/jsautocfg.h/js-confdefs.h/configure.in/Makefile.in, so the responsibility to exercise good taste is entirely on the reviewer here. ;-)
Assignee: general → jorendorff
Attachment #548854 -
Flags: review?(ted.mielczarek)
Comment on attachment 548854 [details] [diff] [review]
v1
We should fix this other locations though ...
Attachment #548854 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Attachment #548854 -
Attachment is obsolete: true
Attachment #549204 -
Flags: review?(jimb)
|
||
Comment 5•14 years ago
|
||
Comment on attachment 549204 [details] [diff] [review]
v2 - cover all of js/src at least
Review of attachment 549204 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #549204 -
Flags: review?(jimb) → review+
|
|
Assignee | |
Comment 6•14 years ago
|
||
Whiteboard: [inbound]
|
||
Comment 7•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in
before you can comment on or make changes to this bug.
Description
•