674696 - Please remove proprietary extensions to Event or standardize them

Status: NEW

(Core :: DOM: Events, task, P3)

Description

[Anne (:annevk)]

Everything at https://searchfox.org/mozilla-central/source/dom/webidl/Event.webidl#64-88 really ought not to exist at all.

Comment 1

[Anne (:annevk)]

See also: http://lists.w3.org/Archives/Public/www-dom/2011JulSep/0039.html

Comment 2

[Anne (:annevk)]

https://bugs.webkit.org/show_bug.cgi?id=65283 is the WebKit bug.

Comment 3

[Alex Vincent [:WeirdAl]]

originalTarget and explicitOriginalTarget are necessary for XBL 1 - they expose shadow content event targets.

Comment 4

[Boris Zbarsky [:bzbarsky]]

We can maybe remove getPreventDefault once we implement defaultPrevented, unless sites are sniffing and relying on it, in which case it probably needs to be standardized as an alize for defaultPrevented.

The prevent* stuff has been deprecated for a while and I suspect can go.

The original target stuff is indeed needed for XBL1, but I wonder whether we can expose it to system-principal code only like we do baseURIObject and nodePrincipal.  That ought to be good enough for our uses.

The various constants might need standandizing.  Not sure.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to comment #4)
> We can maybe remove getPreventDefault once we implement defaultPrevented,

We already do, bug 656954.

Comment 6

[Anne (:annevk)]

There's still a few members left: https://searchfox.org/mozilla-central/source/dom/webidl/Event.webidl#63.

Comment 7

[Boris Zbarsky [:bzbarsky]]

The four *_MASK constants we should try to figure out whether anyone uses in the wild; I'm not quite sure how to do that.  We can scrub them from our code pretty straightforwardly.  It's not clear to me what exactly in-the-wild uses would look like, since you can't do anything with these constants directly.

That leaves originalTarget and explicitOriginalTarget.  We could pretty easily restrict these to chrome-or-xbl, I expect.  The question is whether anyone uses them on the web.  I guess we could try adding telemetry for non-chrome-or-xbl uses...