674768 - Make the default value for auth in baseapp "off"

Status: VERIFIED FIXED

(Cloud Services :: Server: Core, defect)

Description

[Toby Elliott [:telliott]]

In general, the default for auth should not be that it exists and has to be turned off. It might even be enough to look for a specific [auth] section in config, combined with any routes that specify that they need auth.

Comment 1

[Tarek Ziadé (:tarek)]

This is a three-fold patch:

- make reg force the auth option
- make storage force the auth option
- change the default in core

Comment 2

[Tarek Ziadé (:tarek)]

Attachment: Make the app explictely define the auth class

Comment 3

[Tarek Ziadé (:tarek)]

Attachment: Make the app explictely define the auth class [reg]

Comment 4

[Tarek Ziadé (:tarek)]

Attachment: Make baseapp auth class turned off by default

Comment 5

[Rob Miller [:rmiller]]

Comment on attachment 548974 [details] [diff] [review]
Make the app explictely define the auth class [reg]

Review of attachment 548974 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 6

[Rob Miller [:rmiller]]

Comment on attachment 548977 [details] [diff] [review]
Make baseapp auth class turned off by default

Review of attachment 548977 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 7

[Ryan Tilder [:rtilder]]

Comment on attachment 548977 [details] [diff] [review]
Make baseapp auth class turned off by default

Review of attachment 548977 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 8

[Tarek Ziadé (:tarek)]

- reg: http://hg.mozilla.org/services/server-reg/rev/3f6e56f5e857
- storage: http://hg.mozilla.org/services/server-storage/rev/bdae0dc3f334
- core: http://hg.mozilla.org/services/server-core/rev/df16a6d6d04d

Comment 9

[Ryan Tilder [:rtilder]]

Attachment: Correct a missing import that I missed during review of storage wsgiapp.py

Attachment 548977 [details] [diff] breaks syncstorage.wsgiapp's import of the Authentication from services.baseapp.

This is a quick one liner to correct the import.

Comment 10

[Ryan Tilder [:rtilder]]

See comment #9

Comment 12

[Ryan Tilder [:rtilder]]

Attachment: add auth_class=Authentication to set_app() call in syncserver/__init__.py

We missed server-full in the set_app() changes.

Comment 13

[Tarek Ziadé (:tarek)]

everything was applied, closing