674820 - input/textarea.selectionStart/selectionEnd/selectionDirection should not require the presence of a frame

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[(no longer active)]

"All elements to which this API applies have either a selection or a text entry cursor position at all times (even for elements that are not being rendered). User agents should follow platform conventions to determine their initial state."

We currently rely on frames to get these values.  We should start caching them on the content node instead.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Bug 674484?

Comment 2

[Mounir Lamouri (:mounir)]

Seems indeed to be a dup of bug 674484.

Comment 3

[(no longer active)]

No, not at all.  The selection is still retrieved from layout, and in order not to depend on the layout, we need to cache the offsets when we don't have a frame (I have a patch for that).

Bug 674484 is about moving the code around.  That would make things cleaner, but shouldn't have any behavioral effects.

Comment 4

[(no longer active)]

Attachment: Patch (v1)

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 549475 [details] [diff] [review]
Patch (v1)

r=me, but maybe we should look into a common superclass for input and textarea?  They're duplicating more and more logic....

Comment 6

[(no longer active)]

(In reply to comment #5)
> Comment on attachment 549475 [details] [diff] [review] [diff] [details] [review]
> Patch (v1)
> 
> r=me, but maybe we should look into a common superclass for input and
> textarea?  They're duplicating more and more logic....

The thing which kind of disgusts me about nsHTMLInputElement is that it has to deal with both text and non-text input types, but yes, I think we should do that.  Filed bug 676519.

Comment 7

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/2112b458c8c7