674837 - Fennec android builds are not thumb anymore

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mike Hommey [:glandium]]

Since the switch to NDK 5, fennec android builds are not built with -mthumb -march=armv7-a -mfpu=vfp -mfloat-abi=soft-float.

This is because the new target name doesn't match what is checked in configure.in to put these flags.

I think it's time to stop using $target to do these kind of selections, and use our normalized values such as CPU_ARCH and OS_TARGET instead.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Properly set android build options on NDK5+

Comment 2

[Mike Hommey [:glandium]]

Attachment: Properly set android build options on NDK5+ - nspr part

Comment 3

[Mike Hommey [:glandium]]

(In reply to comment #0)
> Since the switch to NDK 5, fennec android builds are not built with -mthumb
> -march=armv7-a -mfpu=vfp -mfloat-abi=soft-float.

This makes the binary significantly bigger, as well as the apk. I'd also expect some talos regression...

Comment 4

[Mike Hommey [:glandium]]

Attachment: Properly set android build options on NDK5+ - nspr part

with configure

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 549042 [details] [diff] [review]
Properly set android build options on NDK5+

Review of attachment 549042 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 549054 [details] [diff] [review]
Properly set android build options on NDK5+ - nspr part

Review of attachment 549054 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 7

[Mike Hommey [:glandium]]

Attachment: Properly set android build options on NDK5+

Comment 8

[Mike Hommey [:glandium]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/f7c8248747d6

Comment 10

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/f7c8248747d6