674880 - Fennec android builds are not thumb anymore - NSPR part

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[Mike Hommey [:glandium]]

+++ This bug was initially created as a clone of Bug #674837 +++

Since the switch to NDK 5, fennec android builds are not built with -mthumb -march=armv7-a -mfpu=vfp -mfloat-abi=soft-float.

This is because the new target name doesn't match what is checked in configure.in to put these flags.

I think it's time to stop using $target to do these kind of selections, and use our normalized values such as CPU_ARCH and OS_TARGET instead.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Properly set android build options on NDK5+ - NSPR part.

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 549085 [details] [diff] [review]
Properly set android build options on NDK5+ - NSPR part.

Carrying over ted's r+ from bug 674837

Comment 3

[(not currently active) Ted Mielczarek]

Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.308; previous revision: 1.307
done
Checking in configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.310; previous revision: 1.309
done