Closed Bug 674880 Opened 8 years ago Closed 8 years ago

Fennec android builds are not thumb anymore - NSPR part

Categories

(NSPR :: NSPR, defect)

4.8.9
ARM
Android
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #674837 +++

Since the switch to NDK 5, fennec android builds are not built with -mthumb -march=armv7-a -mfpu=vfp -mfloat-abi=soft-float.

This is because the new target name doesn't match what is checked in configure.in to put these flags.

I think it's time to stop using $target to do these kind of selections, and use our normalized values such as CPU_ARCH and OS_TARGET instead.
Summary: Fennec android builds are not thumb anymore → Fennec android builds are not thumb anymore - NSPR part
Comment on attachment 549085 [details] [diff] [review]
Properly set android build options on NDK5+ - NSPR part.

Carrying over ted's r+ from bug 674837
Attachment #549085 - Flags: review+
Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.308; previous revision: 1.307
done
Checking in configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.310; previous revision: 1.309
done
Assignee: wtc → mh+mozilla
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Version: other → 4.8.9
Target Milestone: --- → 4.8.9
You need to log in before you can comment on or make changes to this bug.