GLXBadDrawable error with OpenGL layers on X11

RESOLVED FIXED in mozilla8

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mattwoodrow, Unassigned)

Tracking

(Blocks: 1 bug)

unspecified
mozilla8
x86
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Created attachment 549255 [details] [diff] [review]
Use global shared context for GLTextures

Getting this error on try server from attempting to call MakeCurrent (to delete a GLTexture object) on a context after the window has been destroyed.

We should free these objects with the global shared context instead.
(Reporter)

Updated

6 years ago
Attachment #549255 - Attachment is patch: true
Attachment #549255 - Attachment mime type: message/rfc822 → text/plain
Attachment #549255 - Flags: review?(joe)
Is there any downside to allocating with the global shared context? I have this vague memory of it being slow.
Summary: GLXBadDrawbale error with OpenGL layers on X11 → GLXBadDrawable error with OpenGL layers on X11
(Reporter)

Updated

6 years ago
Blocks: 594876
(Reporter)

Comment 2

6 years ago
Created attachment 549697 [details] [diff] [review]
Use global shared context to release GLTextures if the current context has been destroyed

I'm not sure, but I believe you!

With liberal application of printf-tryserver-debugging, I've found that this only happens when IsDestroyed() is also returning true for the context.

We should use the global shared context to release the texture in this case.

Tryserver is currently broken, still waiting on results.
Attachment #549255 - Attachment is obsolete: true
Attachment #549255 - Flags: review?(joe)
Attachment #549697 - Flags: review?
(Reporter)

Updated

6 years ago
Attachment #549697 - Flags: review? → review?(joe)
(Reporter)

Comment 3

6 years ago
Computer says yes.
Comment on attachment 549697 [details] [diff] [review]
Use global shared context to release GLTextures if the current context has been destroyed

The patch description will need changing :)
Attachment #549697 - Flags: review?(joe) → review+
(Reporter)

Comment 5

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/1edc576938dc
http://hg.mozilla.org/mozilla-central/rev/1edc576938dc
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
Blocks: 628214
You need to log in before you can comment on or make changes to this bug.