Last Comment Bug 675073 - GLXBadDrawable error with OpenGL layers on X11
: GLXBadDrawable error with OpenGL layers on X11
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: x86 Linux
: -- normal (vote)
: mozilla8
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
Depends on:
Blocks: ogl-linux-beta 628214
  Show dependency treegraph
 
Reported: 2011-07-28 15:51 PDT by Matt Woodrow (:mattwoodrow)
Modified: 2011-08-16 16:29 PDT (History)
6 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Use global shared context for GLTextures (814 bytes, patch)
2011-07-28 15:51 PDT, Matt Woodrow (:mattwoodrow)
no flags Details | Diff | Review
Use global shared context to release GLTextures if the current context has been destroyed (1.09 KB, patch)
2011-07-31 15:57 PDT, Matt Woodrow (:mattwoodrow)
joe: review+
Details | Diff | Review

Description Matt Woodrow (:mattwoodrow) 2011-07-28 15:51:13 PDT
Created attachment 549255 [details] [diff] [review]
Use global shared context for GLTextures

Getting this error on try server from attempting to call MakeCurrent (to delete a GLTexture object) on a context after the window has been destroyed.

We should free these objects with the global shared context instead.
Comment 1 Joe Drew (not getting mail) 2011-07-28 15:55:08 PDT
Is there any downside to allocating with the global shared context? I have this vague memory of it being slow.
Comment 2 Matt Woodrow (:mattwoodrow) 2011-07-31 15:57:47 PDT
Created attachment 549697 [details] [diff] [review]
Use global shared context to release GLTextures if the current context has been destroyed

I'm not sure, but I believe you!

With liberal application of printf-tryserver-debugging, I've found that this only happens when IsDestroyed() is also returning true for the context.

We should use the global shared context to release the texture in this case.

Tryserver is currently broken, still waiting on results.
Comment 3 Matt Woodrow (:mattwoodrow) 2011-08-01 00:21:31 PDT
Computer says yes.
Comment 4 Joe Drew (not getting mail) 2011-08-04 14:14:37 PDT
Comment on attachment 549697 [details] [diff] [review]
Use global shared context to release GLTextures if the current context has been destroyed

The patch description will need changing :)
Comment 5 Matt Woodrow (:mattwoodrow) 2011-08-04 18:16:20 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/1edc576938dc
Comment 6 Marco Bonardo [::mak] 2011-08-05 09:07:22 PDT
http://hg.mozilla.org/mozilla-central/rev/1edc576938dc

Note You need to log in before you can comment on or make changes to this bug.