Closed Bug 675073 Opened 11 years ago Closed 11 years ago

GLXBadDrawable error with OpenGL layers on X11

Categories

(Core :: Graphics, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: mattwoodrow, Unassigned)

References

Details

Attachments

(1 file, 1 obsolete file)

Getting this error on try server from attempting to call MakeCurrent (to delete a GLTexture object) on a context after the window has been destroyed.

We should free these objects with the global shared context instead.
Attachment #549255 - Attachment is patch: true
Attachment #549255 - Attachment mime type: message/rfc822 → text/plain
Attachment #549255 - Flags: review?(joe)
Is there any downside to allocating with the global shared context? I have this vague memory of it being slow.
Summary: GLXBadDrawbale error with OpenGL layers on X11 → GLXBadDrawable error with OpenGL layers on X11
I'm not sure, but I believe you!

With liberal application of printf-tryserver-debugging, I've found that this only happens when IsDestroyed() is also returning true for the context.

We should use the global shared context to release the texture in this case.

Tryserver is currently broken, still waiting on results.
Attachment #549255 - Attachment is obsolete: true
Attachment #549255 - Flags: review?(joe)
Attachment #549697 - Flags: review?
Attachment #549697 - Flags: review? → review?(joe)
Computer says yes.
Comment on attachment 549697 [details] [diff] [review]
Use global shared context to release GLTextures if the current context has been destroyed

The patch description will need changing :)
Attachment #549697 - Flags: review?(joe) → review+
http://hg.mozilla.org/mozilla-central/rev/1edc576938dc
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
Blocks: 628214
You need to log in before you can comment on or make changes to this bug.