Note: There are a few cases of duplicates in user autocompletion which are being worked on.

portrait view shifted on tablet awesomescreen

VERIFIED FIXED in Firefox 6

Status

Fennec Graveyard
General
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: tchung, Assigned: mfinkle)

Tracking

({regression, verified-aurora, verified-beta})

Trunk
Firefox 6
All
Android
regression, verified-aurora, verified-beta

Details

Attachments

(3 attachments)

(Reporter)

Description

6 years ago
Created attachment 549403 [details]
tablet all pages screenshot

The viewing space on portrait view of tablet doesnt seem to fit on firefox 6 beta.   it does look find on Firefox 5, released builds.  It also works on phones.

See screenshots.

Repro:
1) Install Firefox 6 beta, and nightlies, on a Honeycomb Tablet.  (Xoom, Android 3.1)
- Mozilla/5.0 (Android; Linux armv71; rv:6.0) Gecko/20110721 Firefox/6.0 Fennec/6.0
2) set device in portrait mode, and visit awesomescreen
3) verify portrait view visibility is shifted
(Reporter)

Comment 1

6 years ago
Created attachment 549404 [details]
tablet view - sync setup screenshot
(Reporter)

Comment 2

6 years ago
we should get this fixed for next Fx 6 beta. nom'ing
tracking-fennec: --- → ?
(Reporter)

Comment 3

6 years ago
just checked 20110729 nightly against a HTC Flyer, 7" tablet.   Viewing area looks fine there.  it's running Gingerbread, and does not have the new tablet theming.

So far its only appearing on a 10" wide view tablet.
This is a regression from bug 655740. We are applying a style to all "panel-row-button" buttons, but should only apply them to the buttons in the preference container.
Created attachment 549885 [details] [diff] [review]
patch

This patch makes the CSS more explicit and only applies it to the preference panel buttons.

The Awesomescreen buttons already have CSS to "switch" in portrait mode:
http://mxr.mozilla.org/mozilla-central/source/mobile/themes/core/platform.css#688
Assignee: nobody → mark.finkle
Attachment #549885 - Flags: review?(wjohnston)
Attachment #549885 - Flags: review?(wjohnston) → review+
pushed http://hg.mozilla.org/mozilla-central/rev/4338bea0bb71
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Blocks: 655740
status-firefox5: --- → unaffected
status-firefox6: --- → affected
status-firefox7: --- → affected
status-firefox8: --- → fixed
Target Milestone: --- → Firefox 8
Comment on attachment 549885 [details] [diff] [review]
patch

Requesting approval for Aurora (Firefox 7) and Beta (Firefox 6).  This is a two-line mobile-only change (zero desktop risk).  It's very low risk (just changes one CSS selector in the mobile chrome to be more specific) and fixes a visible regression in Firefox 6.  It landed on mozilla-central today, so can be tested on the Nightly channel tomorrow.
Attachment #549885 - Flags: approval-mozilla-beta?
Attachment #549885 - Flags: approval-mozilla-aurora?
Attachment #549885 - Flags: approval-mozilla-beta?
Attachment #549885 - Flags: approval-mozilla-beta+
Attachment #549885 - Flags: approval-mozilla-aurora?
Attachment #549885 - Flags: approval-mozilla-aurora+
hg.mozilla.org/releases/mozilla-beta/rev/5290a61c6998
http://hg.mozilla.org/releases/mozilla-aurora/rev/b03971e28880
status-firefox6: affected → fixed
status-firefox7: affected → fixed
Target Milestone: Firefox 8 → Firefox 6
(Reporter)

Comment 9

6 years ago
Verified view fix on Xoom Tablet, Android 3.1

Nightly: Mozilla/5.0 (Android; Linux armv71; rv:8.0a1) Gecko/20110803 Firefox/8.0a1 Fennec/8.0a1

Aurora: Mozilla/5.0 (Android; Linux armv71; rv:7.0a2) Gecko/20110803 Firefox/7.0a2 Fennec/7.0a2

still need to verify on fx6 beta5
Status: RESOLVED → VERIFIED
Keywords: verified-aurora
(Assignee)

Updated

6 years ago
tracking-fennec: ? → ---
(Reporter)

Comment 10

6 years ago
Verified fix on beta 5: Mozilla/5.0 (Android; Linux armv71; rv:6.0) Gecko/20110804 Firefox/76.0 Fennec/6.0
Keywords: verified-beta
Duplicate of this bug: 669797
You need to log in before you can comment on or make changes to this bug.