browser-chrome xpinstall tests leak a lot

RESOLVED FIXED

Status

()

Toolkit
Add-ons Manager
--
major
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: dao, Unassigned)

Tracking

({mlk})

Trunk
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox13 affected, firefox14 affected)

Details

(Whiteboard: [MemShrink:P2])

(Reporter)

Description

7 years ago
See the URI list attached in bug 658738 -- lots of http://example.com/browser/toolkit/mozapps/extensions/test/xpinstall/* in there.

The amount of windows leaked makes me think that some central piece in the test framework or in the actual code must be responsible for this.
(Reporter)

Comment 1

7 years ago
by test framework I mean toolkit/mozapps/extensions/test/browser/head.js
(Reporter)

Comment 2

7 years ago
Err, more likely toolkit/mozapps/extensions/test/xpinstall/head.js
Perhaps related to bug 669240?
(Reporter)

Comment 4

7 years ago
(In reply to comment #3)
> Perhaps related to bug 669240?

Seems very likely.
Depends on: 669240
Whiteboard: [MemShrink]
Assignee: nobody → azakai
Whiteboard: [MemShrink] → [MemShrink:P2]
(Reporter)

Updated

6 years ago
Depends on: 691537
Ftr,
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1331186151.1331190870.3486.gz&fulltext=1
Linux comm-central-trunk debug test mochitest-other on 2012/03/07 21:55:51
{
[toolkit/mozapps/extensions/test/xpinstall/browser_whitelist2.js]
  1 window(s) [url = http://example.com/browser/toolkit/mozapps/extensions/test/xpinstall/installtrigger.html?%7B%22Unsigned%20XPI%22%3A%22http%3A%2F%2Fexample.org%2Fbrowser%2Ftoolkit%2Fmozapps%2Fextensions%2Ftest%2Fxpinstall%2Funsigned.xpi%22%7D]
  1 docShell(s)

[toolkit/mozapps/extensions/test/xpinstall/browser_whitelist5.js]
  1 window(s) [url = http://example.com/browser/toolkit/mozapps/extensions/test/xpinstall/startsoftwareupdate.html?%20http%3A%2F%2Fexample.com%2Fbrowser%2Ftoolkit%2Fmozapps%2Fextensions%2Ftest%2Fxpinstall%2Funsigned.xpi]
  1 docShell(s)

[toolkit/mozapps/extensions/test/xpinstall/browser_whitelist6.js]
  1 window(s) [url = http://example.com/browser/toolkit/mozapps/extensions/test/xpinstall/installchrome.html?%20http%3A%2F%2Fexample.com%2Fbrowser%2Ftoolkit%2Fmozapps%2Fextensions%2Ftest%2Fxpinstall%2Funsigned.xpi]
  1 docShell(s)
}
Blocks: 734148
Assignee: azakai → nobody
status-firefox13: --- → affected
(Reporter)

Comment 6

6 years ago
Bug 695480 made these leaks disappear.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Depends on: 695480
Resolution: --- → FIXED
(Reporter)

Updated

6 years ago
Blocks: 749361
https://tbpl.mozilla.org/php/getParsedLog.php?id=11220002&tree=Firefox&full=1
Rev3 WINNT 5.1 mozilla-central debug test mochitest-other on 2012-04-25 22:53:13 PDT for push cc5254f9825f

V.Fixed
Assignee: nobody → khuey
No longer blocks: 749361
Status: RESOLVED → VERIFIED
status-firefox14: --- → affected
Flags: in-testsuite-
Whiteboard: [MemShrink:P2] → [fixed by bug 695480] [MemShrink:P2]
Target Milestone: --- → mozilla15
Blocks: 749361
No longer blocks: 734148
(In reply to Serge Gautherie (:sgautherie) from comment #5)
> http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1331186151.1331190870.
> 3486.gz&fulltext=1

Moved to bug 749532.
Summary: browser-chrome xpinstall tests leak a lot → [Firefox] browser-chrome xpinstall tests leak a lot
(In reply to Serge Gautherie (:sgautherie) from comment #7)

Oh, leaks are fixed, but code has a "remaining" issue:
{
TEST-INFO | chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/xpinstall/browser_navigateaway2.js | Console message: [JavaScript Error: "can't access dead object" {file: "resource:///components/amWebInstallListener.js" line: 176}]
}

Code is
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/amWebInstallListener.js#175
117 Installer.prototype = {
...
126   checkAllDownloaded: function() {
...
176     if (failed.length > 0) {

PS: SeaMonkey didn't port this test (yet).
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
(Reporter)

Updated

6 years ago
(Reporter)

Updated

6 years ago
Whiteboard: [fixed by bug 695480] [MemShrink:P2] → [MemShrink:P2]
(Reporter)

Updated

6 years ago
Assignee: khuey → nobody
Target Milestone: mozilla15 → ---
(Reporter)

Updated

6 years ago
Summary: [Firefox] browser-chrome xpinstall tests leak a lot → browser-chrome xpinstall tests leak a lot
We're clearly not going to do anything else in this bug.  If there are still issues file a followup please.
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.