Closed Bug 675412 Opened 10 years ago Closed 8 years ago

browser-chrome xpinstall tests leak a lot

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set
major

Tracking

()

RESOLVED FIXED
Tracking Status
firefox13 --- affected
firefox14 --- affected

People

(Reporter: dao, Unassigned)

References

Details

(Keywords: memory-leak, Whiteboard: [MemShrink:P2])

See the URI list attached in bug 658738 -- lots of http://example.com/browser/toolkit/mozapps/extensions/test/xpinstall/* in there.

The amount of windows leaked makes me think that some central piece in the test framework or in the actual code must be responsible for this.
by test framework I mean toolkit/mozapps/extensions/test/browser/head.js
Err, more likely toolkit/mozapps/extensions/test/xpinstall/head.js
Perhaps related to bug 669240?
(In reply to comment #3)
> Perhaps related to bug 669240?

Seems very likely.
Depends on: 669240
Whiteboard: [MemShrink]
Assignee: nobody → azakai
Whiteboard: [MemShrink] → [MemShrink:P2]
Depends on: 691537
Assignee: azakai → nobody
Bug 695480 made these leaks disappear.
Status: NEW → RESOLVED
Closed: 9 years ago
Depends on: hueyfix
Resolution: --- → FIXED
Blocks: 749361
https://tbpl.mozilla.org/php/getParsedLog.php?id=11220002&tree=Firefox&full=1
Rev3 WINNT 5.1 mozilla-central debug test mochitest-other on 2012-04-25 22:53:13 PDT for push cc5254f9825f

V.Fixed
Assignee: nobody → khuey
No longer blocks: 749361
Status: RESOLVED → VERIFIED
Flags: in-testsuite-
Whiteboard: [MemShrink:P2] → [fixed by bug 695480] [MemShrink:P2]
Target Milestone: --- → mozilla15
(In reply to Serge Gautherie (:sgautherie) from comment #5)
> http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1331186151.1331190870.
> 3486.gz&fulltext=1

Moved to bug 749532.
Summary: browser-chrome xpinstall tests leak a lot → [Firefox] browser-chrome xpinstall tests leak a lot
(In reply to Serge Gautherie (:sgautherie) from comment #7)

Oh, leaks are fixed, but code has a "remaining" issue:
{
TEST-INFO | chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/xpinstall/browser_navigateaway2.js | Console message: [JavaScript Error: "can't access dead object" {file: "resource:///components/amWebInstallListener.js" line: 176}]
}

Code is
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/amWebInstallListener.js#175
117 Installer.prototype = {
...
126   checkAllDownloaded: function() {
...
176     if (failed.length > 0) {

PS: SeaMonkey didn't port this test (yet).
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Whiteboard: [fixed by bug 695480] [MemShrink:P2] → [MemShrink:P2]
Assignee: khuey → nobody
Target Milestone: mozilla15 → ---
Summary: [Firefox] browser-chrome xpinstall tests leak a lot → browser-chrome xpinstall tests leak a lot
We're clearly not going to do anything else in this bug.  If there are still issues file a followup please.
Status: REOPENED → RESOLVED
Closed: 9 years ago8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.