Closed Bug 675472 Opened 13 years ago Closed 13 years ago

Incorrect return of NS_ERROR_* codes in functions returning PRBool (in comm-central)

Categories

(Thunderbird :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 8.0

People

(Reporter: mwu, Assigned: mwu)

References

Details

Attachments

(1 file)

Attached patch FixSplinter Review
Problems discovered by static analysis and patched by hand.

standard8, want to review this patch? I don't know comm-central well enough to know who to ask for review.
Attachment #549615 - Flags: review?(mbanner)
Comment on attachment 549615 [details] [diff] [review]
Fix

Bienvenu, can you review this?
Attachment #549615 - Flags: review?(dbienvenu)
Comment on attachment 549615 [details] [diff] [review]
Fix

Thanks, looks good, sorry for the delay.
Attachment #549615 - Flags: review?(mbanner)
Attachment #549615 - Flags: review?(dbienvenu)
Attachment #549615 - Flags: review+
https://hg.mozilla.org/comm-central/rev/53a2ab491117
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 8.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: