675586 - tab close button is moving

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:5.0.1) Gecko/20100101 Firefox/5.0.1
Build ID: 20110707182747

Steps to reproduce:

When a "closable" tab is opened and active (Add-on manager for example) and I want to close it, when moving mouse over the close button, the button is moving.



Expected results:

It should stay, where it is. ;-)

Comment 1

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: patch v1

Comment 2

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Can somebody (who's able to) review and apply this patch.

Comment 3

[rsx11m]

Comment on attachment 549752 [details] [diff] [review]
patch v1

I don't know if this needs ui-review first as it's more a technical issue, but please add Blake if you think it's necessary.

Comment 4

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

I've tested it and I think it's very simple solution ready for push.

Comment 5

[rsx11m]

Maybe, but even the most trivial patch needs review first...  :-)

Comment 6

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: patch v2

Comment 7

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Who's "Blake" I should add him to review this patch?

Comment 8

[rsx11m]

I would have added Blake only if ui-review was required, which I don't think is the case here. Go into the "Details" of your updated patch, then select "?" from the menu next to the "review" field underneath and copy-paste the e-mail address which I've used for your first patch into the field next to it to request review.

Comment 9

[Blake Winton (:bwinton) (:☕️)]

(You can also type ":bwinton" into the field, and it'll magically turn into me.)

Thanks,
Blake.

Comment 10

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 550354 [details] [diff] [review]
patch v2

Review of attachment 550354 [details] [diff] [review]:
-----------------------------------------------------------------

I could reproduce the problem, and this patch seemed to fix it, so r=me!

(While I'm here, the patch contains the wrong line endings, so it didn't apply cleanly for me.  It was easy enough to fix by hand, but in the future, you'll have to find a way to clean those up automatically.)

Thanks,
Blake.

Comment 11

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Weird, I am unable to mark this bug as fixed. Or do I need more reviews?

@bwinton: I am not sure what do you mean about wrong line endings.

Comment 12

[Mark Banner (:standard8)]

(In reply to Michal Stanke from comment #11)
> Weird, I am unable to mark this bug as fixed. Or do I need more reviews?

You have enough reviews, so the patch needs to be landed before you it can be marked as fixed, hence I've added checkin-needed to the keywords.

Comment 13

[Jonathan Protzenko [:protz]]

Hi,

Thanks for your patch! The patch did not apply cleanly because, I think, it has DOS line-endings and the file has Unix line-endings. I fixed that, but you might want to make sure that doesn't happen in the future.

Thanks for this very nice contribution, I'm hoping to checkin more patches of yours in the future!

http://hg.mozilla.org/comm-central/rev/eb67c51afb72