Closed Bug 675589 Opened 9 years ago Closed 8 years ago

Group all session restore menu items together.

Categories

(SeaMonkey :: Bookmarks & History, defect)

x86
Windows Vista
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ewong, Assigned: ewong)

Details

Attachments

(1 file, 1 obsolete file)

This bug was spun off from the comments attributed to bug #599731c11 and
bug #599731c12.  

Meaning group all restore session menu items together.
Ok, further comment.  Bug #599731 moved the Recently Closed menu items from
the File menu to the Go Menu.  Now basically, the "Restore Previous Session" 
should be 'grouped' with these menus.
Assignee: nobody → ewong
Status: NEW → ASSIGNED
On the first view, the Go menu has an extra disabled "Tab from other computers" menu item.  Subsequent views, that item disappears.
Comment on attachment 559084 [details] [diff] [review]
Group all session restore menu items (v1)

>+          endHistory.hidden = (endHistory == aParent.lastChild) || (syncMenuItem.hidden);

Since you didn't ask anyone specifically for review yet, here's a drive-by: Technically, no parentheses is needed here at all. Personally I'd go with one (for everything on the right side), but the reviewer you choose might disagree.
Attachment #559084 - Attachment is obsolete: true
Attachment #582743 - Flags: review?(iann_bugzilla)
Attachment #582743 - Flags: review?(iann_bugzilla) → review+
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/b9f97ed7e628
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.