Group all session restore menu items together.

RESOLVED FIXED

Status

SeaMonkey
Bookmarks & History
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: ewong, Assigned: ewong)

Tracking

Trunk
x86
Windows Vista

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
This bug was spun off from the comments attributed to bug #599731c11 and
bug #599731c12.  

Meaning group all restore session menu items together.
(Assignee)

Comment 1

7 years ago
Ok, further comment.  Bug #599731 moved the Recently Closed menu items from
the File menu to the Go Menu.  Now basically, the "Restore Previous Session" 
should be 'grouped' with these menus.
(Assignee)

Updated

7 years ago
Assignee: nobody → ewong
Status: NEW → ASSIGNED
(Assignee)

Comment 2

7 years ago
Created attachment 559084 [details] [diff] [review]
Group all session restore menu items (v1)

On the first view, the Go menu has an extra disabled "Tab from other computers" menu item.  Subsequent views, that item disappears.
Comment on attachment 559084 [details] [diff] [review]
Group all session restore menu items (v1)

>+          endHistory.hidden = (endHistory == aParent.lastChild) || (syncMenuItem.hidden);

Since you didn't ask anyone specifically for review yet, here's a drive-by: Technically, no parentheses is needed here at all. Personally I'd go with one (for everything on the right side), but the reviewer you choose might disagree.
(Assignee)

Comment 4

6 years ago
Created attachment 582743 [details] [diff] [review]
Group all session restore menu items together (v2)
Attachment #559084 - Attachment is obsolete: true
Attachment #582743 - Flags: review?(iann_bugzilla)

Updated

6 years ago
Attachment #582743 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 5

6 years ago
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/b9f97ed7e628
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.