The default bug view has changed. See this FAQ.

Move "Recently Closed" menus to Go menu

RESOLVED FIXED in seamonkey2.5

Status

SeaMonkey
Bookmarks & History
--
enhancement
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: Aki Laaksovirta, Assigned: ewong)

Tracking

unspecified
seamonkey2.5
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

7 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US) AppleWebKit/534.3 (KHTML, like Gecko) Chrome/6.0.472.63 Safari/534.3
Build Identifier: 

I think that the "Recently Closed Tabs" and the "Recently Closed Windows" menus should be moved from the File menu to the Go menu.The reasons:

* They are not related to the current page, but they are rather a part of the "browsing history" in the broader sense.

*The File menu typically contains items that are related to opening or saving files.

Reproducible: Always

Comment 1

7 years ago
I'm working on porting on demand restore session, deciding where to place it's menu entry. My first though is File menu, bug i decided to place it to Go menu. Also i propose rename Go menu to History, which will better reflect it's entries.
(Reporter)

Comment 2

7 years ago
> Also i propose rename Go menu to History, which will better reflect it's
> entries.

I agree, but you should probably file a separate bug about that.
Valid request, so confirming. Doesn't need to be decided now, though.
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Updated

6 years ago
Assignee: nobody → ewong
Status: NEW → ASSIGNED
(Assignee)

Comment 4

6 years ago
Created attachment 544465 [details] [diff] [review]
Moved "Recently Closed" menus to Go Menu.
Attachment #544465 - Flags: review?(iann_bugzilla)

Comment 5

6 years ago
Comment on attachment 544465 [details] [diff] [review]
Moved "Recently Closed" menus to Go Menu.

>+++ b/suite/browser/navigatorOverlay.xul

>+        <menu label="&recentTabs.label;"
>+              accesskey="&recentTabs.accesskey;"
>+              id="menu_recentTabs">
Nit: I'd prefer the id to be first.
>+          <menupopup id="menu_recentTabsPopup"
>+                     onpopupshowing="updateRecentTabs(this);"
>+                     oncommand="gBrowser.undoCloseTab(event.target.value);"/>
>+        </menu>
>+        <menu label="&recentWindows.label;"
>+              accesskey="&recentWindows.accesskey;"
>+              id="menu_recentWindows">
Nit: id first please

>+++ b/suite/locales/en-US/chrome/browser/navigator.dtd
>@@ -14,22 +14,16 @@
>+<!ENTITY recentTabs.label "Recently Closed Tabs">
>+<!ENTITY recentTabs.accesskey "R">
You will have to change this accesskey, perhaps "C", as "Restore Previous Session" already uses "R".

>+<!ENTITY recentTabs.commandkey "t">
>+<!ENTITY recentWindows.label "Recently Closed Windows">
>+<!ENTITY recentWindows.accesskey "y">
>+<!ENTITY recentWindows.commandkey "y">
> <!ENTITY historyRestoreLastSession.label "Restore Previous Session">
> <!ENTITY historyRestoreLastSession.accesskey "R">

Does help need changing to reflect this new menu structure?
Attachment #544465 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Updated

6 years ago
Duplicate of this bug: 400503
(Assignee)

Comment 7

6 years ago
(In reply to comment #5)
> Does help need changing to reflect this new menu structure?

Filed bug #670513.
(Assignee)

Updated

6 years ago
Depends on: 670513
(Assignee)

Comment 8

6 years ago
Created attachment 545069 [details] [diff] [review]
Moved "Recently Closed" menus to Go Menu.(v2) [Checked in: Comment 9]
Attachment #544465 - Attachment is obsolete: true
Attachment #545069 - Flags: review?(iann_bugzilla)

Updated

6 years ago
Attachment #545069 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed

Comment 9

6 years ago
Comment on attachment 545069 [details] [diff] [review]
Moved "Recently Closed" menus to Go Menu.(v2) [Checked in: Comment 9]

http://hg.mozilla.org/comm-central/rev/b1075fd310df
Attachment #545069 - Attachment description: Moved "Recently Closed" menus to Go Menu.(v2) → Moved "Recently Closed" menus to Go Menu.(v2) [Checked in: Comment 9]

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.5
(In reply to comment #5)
>(From update of attachment 544465 [details] [diff] [review])
>>+<!ENTITY recentTabs.label "Recently Closed Tabs">
>>+<!ENTITY recentTabs.accesskey "R">
>You will have to change this accesskey, perhaps "C", as "Restore Previous
>Session" already uses "R".
Why not "T"?

Would it make sense to group all the session restore items together?

Comment 11

6 years ago
(In reply to comment #10)
> (In reply to comment #5)
> >(From update of attachment 544465 [details] [diff] [review] [diff] [details] [review])
> >>+<!ENTITY recentTabs.label "Recently Closed Tabs">
> >>+<!ENTITY recentTabs.accesskey "R">
> >You will have to change this accesskey, perhaps "C", as "Restore Previous
> >Session" already uses "R".
> Why not "T"?
I do keep forgetting that "T" has a fairly wide underscore when an accesskey.
> 
> Would it make sense to group all the session restore items together?
Indeed that is an option, could both be done in a spin off bug...
(In reply to comment #11)
> (In reply to comment #10)
> > (In reply to comment #5)
> > >(From update of attachment 544465 [details] [diff] [review])
> > >>+<!ENTITY recentTabs.label "Recently Closed Tabs">
> > >>+<!ENTITY recentTabs.accesskey "R">
> > >You will have to change this accesskey, perhaps "C", as "Restore Previous
> > >Session" already uses "R".
> > Why not "T"?
> I do keep forgetting that "T" has a fairly wide underscore when an accesskey.
> > Would it make sense to group all the session restore items together?
> Indeed that is an option, could both be done in a spin off bug...
Of course. I only mention it because I had to build Firefox to debug bug 671466 and I liked the order that they've put their menuitems in.
(Assignee)

Comment 13

6 years ago
(In reply to comment #11)

> > Would it make sense to group all the session restore items together?
> Indeed that is an option, could both be done in a spin off bug...

Spun off bug #675589.
The code to enable and disable the menus was unfortunately hidden away at the end of updateCloseItems. This needs to be moved into a new function so that it can be called from the go popup.

Updated

6 years ago
Depends on: 675672

Comment 15

6 years ago
The relevant code to be moved starts at http://mxr.mozilla.org/comm-central/source/suite/browser/navigator.js#1500
You will need to add a onpopupshowing to the "history-menu" http://mxr.mozilla.org/comm-central/source/suite/browser/navigatorOverlay.xul#380
This could probably be done in bug 675672 as part of that work.

Updated

5 years ago
Depends on: 702297

Updated

5 years ago
Keywords: relnote
added bug 599731 / bug 702297 to Known Issues

Checking in seamonkey2.5/index.en.html;
/www/seamonkeyproject-org/src/releases/seamonkey2.5/index.en.html,v  <--  index.en.html
new revision: 1.10; previous revision: 1.9
done
Keywords: relnote
You need to log in before you can comment on or make changes to this bug.