675690 - Full Screen menuitem should be disabled when no windows are open

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Stefan [:stefanh]]

When I fixed bug 606297, I forgot to disable the menuitem when the only open window is the hidden one. Also, I don't think we should keep the Recently Closed Tabs menu enabled - it relies on stuff that's not available (no browser).

Comment 1

[Stefan [:stefanh]]

Bah, the Zoom menuitem is missing its label when no windows are open :-(

Comment 2

[Stefan [:stefanh]]

(In reply to comment #1)
> Bah, the Zoom menuitem is missing its label when no windows are open :-(

Filed bug 676279 for this, since it felt like a different beast.

Comment 3

[Stefan [:stefanh]]

Ah, right, I forgot: We also have a js error from the remaining Recently Closed Windows menu because of the updateGoMenu residing in sessionHistoryUI.js. Including that file in hiddenWindow.xul, make us hit sessionHistoryUI.js, line 70 where getWebNavigation() is null...

Comment 4

[Stefan [:stefanh]]

I'm going to file a new bug for the "Recently Closed ... " menus. I think it'll take a bit more time to fix them properly. Ideally, they should be enabled.

Comment 5

[Stefan [:stefanh]]

Attachment: Simple fix

Comment 6

[Stefan [:stefanh]]

(In reply to comment #4)
> I'm going to file a new bug for the "Recently Closed ... " menus. I think
> it'll take a bit more time to fix them properly. Ideally, they should be
> enabled.

Filed bug 676330.

Comment 7

[Karsten Düsterloh]

Comment on attachment 550437 [details] [diff] [review]
Simple fix

>diff --git a/suite/browser/navigator.js b/suite/browser/navigator.js
>-                       'menuitem_reload', 'menu_UseStyleSheet', 'charsetMenu',
>-                       'View:PageSource', 'View:PageInfo', 'menu_translate',
>-                       'cookie_deny', 'cookie_default',
>+                       'View:FullScreen', 'menuitem_reload', 'menu_UseStyleSheet',
>+                       'charsetMenu', 'View:PageSource', 'View:PageInfo',
>+                       'menu_translate', 'cookie_deny', 'cookie_default',

Bah, this is why "stuffing stuff into lines" is just bad — you want to do a single small change and you have to reorder the world. :-(
Permission granted to reformat disabledItems to one command id per line to get it straight.

Comment 8

[Stefan [:stefanh]]

I just added 'View:FullScreen' after 'cookie_default'

http://hg.mozilla.org/comm-central/rev/5f9ac7a79f69