Closed Bug 675690 Opened 10 years ago Closed 9 years ago

Full Screen menuitem should be disabled when no windows are open

Categories

(SeaMonkey :: UI Design, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.5

People

(Reporter: stefanh, Assigned: stefanh)

References

Details

Attachments

(1 file)

When I fixed bug 606297, I forgot to disable the menuitem when the only open window is the hidden one. Also, I don't think we should keep the Recently Closed Tabs menu enabled - it relies on stuff that's not available (no browser).
Bah, the Zoom menuitem is missing its label when no windows are open :-(
(In reply to comment #1)
> Bah, the Zoom menuitem is missing its label when no windows are open :-(

Filed bug 676279 for this, since it felt like a different beast.
Ah, right, I forgot: We also have a js error from the remaining Recently Closed Windows menu because of the updateGoMenu residing in sessionHistoryUI.js. Including that file in hiddenWindow.xul, make us hit sessionHistoryUI.js, line 70 where getWebNavigation() is null...
I'm going to file a new bug for the "Recently Closed ... " menus. I think it'll take a bit more time to fix them properly. Ideally, they should be enabled.
Summary: Disable Full Screen menuitem and Recently Closed Tabs menu if hiddenwindow is the only window → Full Screen menuitem should be disabled when no windows are open
Blocks: 606297
Attached patch Simple fixSplinter Review
Attachment #550437 - Flags: review?(mnyromyr)
(In reply to comment #4)
> I'm going to file a new bug for the "Recently Closed ... " menus. I think
> it'll take a bit more time to fix them properly. Ideally, they should be
> enabled.

Filed bug 676330.
Comment on attachment 550437 [details] [diff] [review]
Simple fix

>diff --git a/suite/browser/navigator.js b/suite/browser/navigator.js
>-                       'menuitem_reload', 'menu_UseStyleSheet', 'charsetMenu',
>-                       'View:PageSource', 'View:PageInfo', 'menu_translate',
>-                       'cookie_deny', 'cookie_default',
>+                       'View:FullScreen', 'menuitem_reload', 'menu_UseStyleSheet',
>+                       'charsetMenu', 'View:PageSource', 'View:PageInfo',
>+                       'menu_translate', 'cookie_deny', 'cookie_default',

Bah, this is why "stuffing stuff into lines" is just bad — you want to do a single small change and you have to reorder the world. :-(
Permission granted to reformat disabledItems to one command id per line to get it straight.
Attachment #550437 - Flags: review?(mnyromyr) → review+
I just added 'View:FullScreen' after 'cookie_default'

http://hg.mozilla.org/comm-central/rev/5f9ac7a79f69
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.5
You need to log in before you can comment on or make changes to this bug.