675787 - jsbridge connection not re-established after a restart of Firefox

Status: RESOLVED WORKSFORME

(Testing Graveyard :: Mozmill, defect)

Description

[Jeff Hammel]

See bug 675785 and https://bugzilla.mozilla.org/show_bug.cgi?id=640435#c18 for details.

In short, all of our code paths assume/assert jsbridge is running on port 24242.  If however you tried to run a user restart test and specified some other port on the command line, the command line would vanish and you would get the default port, causing an (e.g.) JSBridgeDisconnectError

bug 675785 should probably be fixed first.   If it is WONTFIXed...not sure where to go from here :/

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

So whether something has been changed for command line arguments or something was broken for you when you have tested that. For me it works perfectly fine in Mozmill 1.5.9 on OS X:

$ mozmill-restart -b /Applications/Firefox/Nightly.app/ --show-errors -t tests/functional/restartTests/testMasterPassword/ -P 10022
jsbridge: Server started on port 10022
TEST-START | /Volumes/data/code/mozmill-tests/nightly/tests/functional/restartTests/testMasterPassword/test1.js | setupModule
TEST-PASS | /Volumes/data/code/mozmill-tests/nightly/tests/functional/restartTests/testMasterPassword/test1.js | test1.js::setupModule
TEST-START | /Volumes/data/code/mozmill-tests/nightly/tests/functional/restartTests/testMasterPassword/test1.js | testSetMasterPassword
*** TOKEN!!!! (name = |[xpconnect wrapped nsIPK11Token]|
TEST-PASS | /Volumes/data/code/mozmill-tests/nightly/tests/functional/restartTests/testMasterPassword/test1.js | test1.js::testSetMasterPassword
jsbridge: Server started on port 10022
TEST-START | /Volumes/data/code/mozmill-tests/nightly/tests/functional/restartTests/testMasterPassword/test2.js | setupModule
WARNING | test2.js::setupModule | (SKIP) Bug 611455: Disconnect error in restart test module testMasterPassword
TEST-START | /Volumes/data/code/mozmill-tests/nightly/tests/functional/restartTests/testMasterPassword/test2.js | testInvokeMasterPassword
WARNING | test2.js::testInvokeMasterPassword | (SKIP) setupModule failed.
jsbridge: Server started on port 10022
TEST-START | /Volumes/data/code/mozmill-tests/nightly/tests/functional/restartTests/testMasterPassword/test3.js | setupModule
TEST-PASS | /Volumes/data/code/mozmill-tests/nightly/tests/functional/restartTests/testMasterPassword/test3.js | test3.js::setupModule
TEST-START | /Volumes/data/code/mozmill-tests/nightly/tests/functional/restartTests/testMasterPassword/test3.js | testRemoveMasterPassword
TEST-PASS | /Volumes/data/code/mozmill-tests/nightly/tests/functional/restartTests/testMasterPassword/test3.js | test3.js::testRemoveMasterPassword
INFO Passed: 4
INFO Failed: 0
INFO Skipped: 2

The port is correctly re-assigned after a restart of Firefox. I will now check Linux and Windows how those platforms behave. If both don't show the issue I would expect it could be a regression in Mozmill 2.0.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

So as my investigation has been shown it works fine on Windows and Linux too. That means we are not blocked by bug 399317.

So something is wrong with Mozmill 2 here. So port is remembered but the restart tests are not getting executed.

Here the results from the 5 user restart tests under Mutt:

$ mozmill -b /Applications/Firefox/Nightly.app/ -t mutt/mutt/tests/js/restart/test_user_restart/ -P 10022 --restart
INFO | port 10022
INFO | 
INFO | port 10022
INFO | 
INFO | port 10022
INFO | 
INFO | port 10022
INFO | 
INFO | port 10022
INFO | 
INFO | Passed: 0
INFO | Failed: 0
INFO | Skipped: 0

This needs further investigation which I will do after Mozmill 1.5.10 has been released. Assigning to myself for now.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This works fine for me now and I can't see any failures:

$ mozmill -b /Applications/Firefox/Nightly.app/ -t mutt/mutt/tests/js/frame
[..]
RESULTS | Passed: 2
RESULTS | Failed: 3
RESULTS | Skipped: 0