675884 - Implement Event constructors

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Anne (:annevk)]

DOM Core introduces a constructor syntax for Events.

http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#dom-event

Please implement it so init*Event() can die in a fire.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Patch coming soon for Event and CustomEvent.
I don't know specs defining other event ctors.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Ah, there are other specs for other event ctors.

But I'll start from Event and CustomEvent.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

This adds the basic stuff (Event and CustomEvent and ctors are defined in DOM4).
After this adding support for new event ctors is easy:
- Create FooEventInit interface
- Add NS_DEFINE_EVENT_CTOR(Foo) and NS_DEFINE_EVENT_CONSTRUCTOR_FUNC_DATA(Foo)
  to nsDOMClassInfo.cpp
- virtual const nsIID& EventInitIID() { return NS_GET_IID(nsIFooEventInit); } 
  to the nsDOMFooEvent.h
- Implement
  virtual nsresult InitFromCtor(const nsAString& aType, nsISupports* aDict);

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

https://tbpl.mozilla.org/?tree=Try&rev=109e5fb30913

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Can you check the expected behaviour for { bubbles: get () { throw foo } } and add a test?

Also, \o/

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Handle exceptions per WebIDL

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 580086 [details] [diff] [review]
patch

>--- a/content/events/src/nsDOMEvent.cpp
>+++ b/content/events/src/nsDOMEvent.cpp
>+nsDOMEvent::Initialize(nsISupports* aOwner, JSContext* aCx, JSObject* aObj,
>+                       PRUint32 aArgc, jsval* aArgv)
>+{
>+  JSAutoRequest ar(aCx);
>+  JSString* jsstr = JS_ValueToString(aCx, aArgv[0]);
>+  if (!jsstr) {
>+    return NS_ERROR_DOM_SYNTAX_ERR;
>+  }
>+
>+  JS::Anchor<JSString*> deleteProtector(jsstr);
>+  size_t length;
>+  const jschar* chars = JS_GetStringCharsAndLength(aCx, jsstr, &length);
>+  if (!chars) {
>+    return NS_ERROR_OUT_OF_MEMORY;
>+  }
>+
>+  nsAutoString type;
>+  type.Assign(chars, length);
>+  deleteProtector.clear();

Can this use nsDependentJSString?

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

I don't know why nsDependentJSString is ever safe to use.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

I'm trying to write a code generator for event ctors.

But feel free to review the current patches.

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

I filed Bug 709569 to get a tool for generic dictionary handling.

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Attachment: using nsDependentJSString

I'll file a followup bug to get better nsDependentJSString <-> JS::Anchor 
handling. nsDependentJSString could just do the right thing with JSString, or at 
least  enforce that JS::Anchor is used.

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 580086 [details] [diff] [review]
patch

er, the previous patch is on top of this.

Comment 13

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/01a26239462a
https://hg.mozilla.org/mozilla-central/rev/1ab5ed4f93bf

Comment 14

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

We really need serious documentation for this...

Comment 15

[Jean-Yves Perrier [:teoli]]

Documentation updated:
Constructor:
https://developer.mozilla.org/en-US/docs/Web/API/Event.Event
https://developer.mozilla.org/en-US/docs/Web/API/CustomEvent.CustomEvent
Interface pages updated:
https://developer.mozilla.org/en-US/docs/Web/API/Event
https://developer.mozilla.org/en-US/docs/Web/API/CustomEvent
init*Event pages deprecated:
https://developer.mozilla.org/en-US/docs/Web/API/Event.initEvent
https://developer.mozilla.org/en-US/docs/Web/API/CustomEvent.initCustomEvent

and
https://developer.mozilla.org/en-US/Firefox/Releases/11#DOM updated