676038 - Remove the top border of #folderTree after landing of Bug 667245

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

After landing of Bug 667245 the folder tree has a white border on top which don't look so good. Removing it makes the tree better blend into the tab.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Remove the border

This patch removes only the border. Maybe we should consider a padding on top to move the treeitems a little bit down. With 4px the items are with the treeitems of the thread tree alignd when QFB is closed. With QFB open this would be 12px.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Comparsion, on bottom with patch

Comment 3

[Jim Porter (:squib)]

Personally, I prefer the old way, since it visually divides the tab from the folder pane.

Also, let's not worry about vertical alignment issues until after we've finished moving all the affected bits around. If we use the transparent thread pane headers, I imagine we could probably shave a few pixels off of them to line everything up and still have things look good.

Comment 4

[Andreas Nilsson (:andreasn)]

Comment on attachment 550144 [details] [diff] [review]
Remove the border

It looks better without the border I think, mostly because previously the side-pane looked like it was bending forward somewhat.

Comment 5

[Andreas Nilsson (:andreasn)]

Comment on attachment 550144 [details] [diff] [review]
Remove the border

And the css looks all right too.

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 550144 [details] [diff] [review]
Remove the border

I'm asking for approval‑comm‑aurora because the hidden sidebar header is now also in comm‑aurora.

Comment 7

[Jonathan Protzenko [:protz]]

http://hg.mozilla.org/comm-central/rev/4c288f2cae3f

Comment 8

[Jonathan Protzenko [:protz]]

http://hg.mozilla.org/releases/comm-aurora/rev/7ad5d6eb7527