676048 - Report RuleCascadeData and friends in about:memory

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Add up lots of hashtables and arrays

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 550155 [details] [diff] [review]
Patch

> +  // We don't bother enumerating this one since all it does is hold a ref to
> an atom

Add a comment in the entry class to fix that if the entry class ever changes?

Please file a followup bug on me to nuke AttributeSelectorEntry and just use AtomSelectorEntry for the attributes table?  I have no idea why that wasn't done in bug 645491 or some followup...  I think it was because I had some other changes to revamp all this selector hashtable stuff but those never landed.

Please use static_cast, not C-style casts.

>+  for (RuleCascadeData * const *cascadep = &mRuleCascades, *cascade;
>+       (cascade = *cascadep); cascadep = &cascade->mNext) {

How about:

  for (RuleCascadeData* cascade = mRuleCascades; cascade; 
       cascade = cascade->mNext) {

It's not like you have to _modify_ the list, unlike RefreshRuleCascades.

r=me with those changes.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch w/review comments

Review comments addressed.  Turns out we should traverse those other hashtables, since RuleHashTagTableEntry inherits from RuleHashTableEntry, we were traversing.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/f185f48d35dc

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 550180 [details] [diff] [review]
Patch w/review comments

This could still use a comment on RuleHashTagTableEntry that says that if any members are added the traverse code will need changing...

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Added a few more comments.

http://hg.mozilla.org/mozilla-central/rev/e1bc7f08fa69