Nuke AttributeSelectorEntry

RESOLVED FIXED in mozilla8

Status

()

Core
CSS Parsing and Computation
P2
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: khuey, Assigned: bz)

Tracking

unspecified
mozilla8
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

It can be completely replaced with AtomSelectorEntry, which is basically identical.
Created attachment 550185 [details] [diff] [review]
Get rid of the malloc-happy AttributeSelectorEntry class.
Attachment #550185 - Flags: review?(dbaron)
Priority: -- → P2
Whiteboard: [need review]
Comment on attachment 550185 [details] [diff] [review]
Get rid of the malloc-happy AttributeSelectorEntry class.

r=dbaron

though I'd note that AtomSelector_CSOps doesn't need the fancy RuleHash_CSMatchEntry (or, as a result, to need AtomSelector_GetKey or any of the RuleHashTableOps fanciness).
Attachment #550185 - Flags: review?(dbaron) → review+
> though I'd note that AtomSelector_CSOps doesn't need the fancy
> RuleHash_CSMatchEntry

Filed bug 676174.
Blocks: 676174
Whiteboard: [need review] → [need landing]
http://hg.mozilla.org/integration/mozilla-inbound/rev/330937aaaeba
Flags: in-testsuite-
Whiteboard: [need landing]
Target Milestone: --- → mozilla8
http://hg.mozilla.org/mozilla-central/rev/330937aaaeba
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.