Last Comment Bug 676057 - Nuke AttributeSelectorEntry
: Nuke AttributeSelectorEntry
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: CSS Parsing and Computation (show other bugs)
: unspecified
: All All
: P2 normal (vote)
: mozilla8
Assigned To: Boris Zbarsky [:bz]
:
Mentors:
Depends on: 676048
Blocks: 676174
  Show dependency treegraph
 
Reported: 2011-08-02 12:52 PDT by Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
Modified: 2011-08-04 03:05 PDT (History)
2 users (show)
bzbarsky: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Get rid of the malloc-happy AttributeSelectorEntry class. (6.86 KB, patch)
2011-08-02 13:38 PDT, Boris Zbarsky [:bz]
dbaron: review+
Details | Diff | Splinter Review

Description Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-08-02 12:52:38 PDT
It can be completely replaced with AtomSelectorEntry, which is basically identical.
Comment 1 Boris Zbarsky [:bz] 2011-08-02 13:38:54 PDT
Created attachment 550185 [details] [diff] [review]
Get rid of the malloc-happy AttributeSelectorEntry class.
Comment 2 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2011-08-02 14:45:57 PDT
Comment on attachment 550185 [details] [diff] [review]
Get rid of the malloc-happy AttributeSelectorEntry class.

r=dbaron

though I'd note that AtomSelector_CSOps doesn't need the fancy RuleHash_CSMatchEntry (or, as a result, to need AtomSelector_GetKey or any of the RuleHashTableOps fanciness).
Comment 3 Boris Zbarsky [:bz] 2011-08-02 20:49:14 PDT
> though I'd note that AtomSelector_CSOps doesn't need the fancy
> RuleHash_CSMatchEntry

Filed bug 676174.
Comment 5 Marco Bonardo [::mak] 2011-08-04 03:05:53 PDT
http://hg.mozilla.org/mozilla-central/rev/330937aaaeba

Note You need to log in before you can comment on or make changes to this bug.