Closed Bug 676240 Opened 9 years ago Closed 9 years ago

Crash [@ nsXULTreeAccessible::GetChildCount()

Categories

(Core :: Disability Access APIs, defect, critical)

Product:
Core
Component:
Disability Access APIs
Version:
5 Branch
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla8

People

(Reporter: jknutson, Assigned: surkov)

References

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

patch
747 bytes, patch
tbsaunde
: review+
Details | Diff | Splinter Review 
User Agent: Mozilla/5.0 (Windows NT 5.1; rv:5.0) Gecko/20100101 Firefox/5.0
Build ID: 20110615151330

Steps to reproduce:

my firefox 5.0 crashes on random websites and i need to restart it over and over


Actual results:

browsesing to a website


Expected results:

it shouldn't crash all day long
i have submitted bug after bug after bug and it doesn't seem like anything is happening
Please provide the crash report IDs from about:crashes from some of your recently submitted crashes.
Crash Signature: [@ nsXULTreeAccessible::GetChildCount() ]
0 	xul.dll 	nsXULTreeAccessible::GetChildCount 	accessible/src/xul/nsXULTreeAccessible.cpp:452
1 	xul.dll 	nsAccessibleWrap::get_accChildCount 	accessible/src/msaa/nsAccessibleWrap.cpp:239
2 	rpcrt4.dll 	Invoke 	
3 	rpcrt4.dll 	NdrStubCall2 	
4 	rpcrt4.dll 	NdrClientMapCommFault 	
5 	oleaut32.dll 	oleaut32.dll@0x129ae 	
6 	ole32.dll 	SyncStubInvoke 	
7 	ole32.dll 	StubInvoke 	
8 	ole32.dll 	IFillLockBytes_FillAppend_Proxy 	
9 	ole32.dll 	COIDHashTable::Compare
Severity: normal → critical
Keywords: crash
Per http://bit.ly/p4W3hE this happens on Firefox 5/6/7/8 Branches.
Component: General → Disability Access APIs
Product: Firefox → Core
QA Contact: general → accessibility-apis
Attached patch patch — — Splinter Review
Assignee: nobody → surkov.alexander
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #550434 - Flags: review?(trev.saunders)
Summary: i crash 8-10 times a day → Crash [@ nsXULTreeAccessible::GetChildCount()
Comment on attachment 550434 [details] [diff] [review]
patch


>+  if (!pcountChildren)
>+    return E_INVALIDARG;
>   *pcountChildren = 0;

blank line after return please.
Attachment #550434 - Flags: review?(trev.saunders) → review+
(In reply to comment #7)

> >+  if (!pcountChildren)
> >+    return E_INVALIDARG;
> >   *pcountChildren = 0;
> 
> blank line after return please.

sure if you like
landed http://hg.mozilla.org/mozilla-central/rev/0e7f85aa8137
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
Duplicate of this bug: 682067
You need to log in before you can comment on or make changes to this bug.