Closed Bug 676556 Opened 12 years ago Closed 12 years ago

GCLI requirejs tests log when they shouldn't

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 8

People

(Reporter: jwalker, Assigned: jwalker)

References

Details

Attachments

(1 file)

[in-fx-team] upload 1
918 bytes, patch
rcampbell
: review+
Details | Diff | Splinter Review 
testUncompilable() shouldn't console.log()
Correct definition of function is:

function testUncompilable() {
  // It's not totally clear how a module loader should perform with unusable
  // modules, however at least it should go into a flat spin ...
  // GCLI mini_require reports an error as it should
  try {
    let unrequireable = require('gclitest/unrequirable');
    fail();
  }
  catch (ex) {
    // expected
  }
}
Assignee: nobody → jwalker
This also fixes to indentation errors in the same function
Attachment #551001 - Flags: review+
Comment on attachment 551001 [details] [diff] [review]
[in-fx-team] upload 1

http://hg.mozilla.org/integration/fx-team/rev/4ec2052b0839
Attachment #551001 - Attachment description: upload 1 → [in-fx-team] upload 1
Whiteboard: [fixed-in-fx-team]
Yeay. Thanks Rob.
http://hg.mozilla.org/mozilla-central/rev/4ec2052b0839
Status: NEW → RESOLVED
Closed: 12 years ago
OS: Windows 7 → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 8
Depends on: 677996
No longer depends on: 677996
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.