Last Comment Bug 676556 - GCLI requirejs tests log when they shouldn't
: GCLI requirejs tests log when they shouldn't
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Firefox 8
Assigned To: Joe Walker [:jwalker] (needinfo me or ping on irc)
:
Mentors:
Depends on:
Blocks: GCLI-ENABLE
  Show dependency treegraph
 
Reported: 2011-08-04 09:06 PDT by Joe Walker [:jwalker] (needinfo me or ping on irc)
Modified: 2011-08-10 15:34 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
[in-fx-team] upload 1 (918 bytes, patch)
2011-08-05 04:35 PDT, Joe Walker [:jwalker] (needinfo me or ping on irc)
rcampbell: review+
Details | Diff | Review

Description Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-08-04 09:06:16 PDT
testUncompilable() shouldn't console.log()
Comment 1 Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-08-04 09:25:11 PDT
Correct definition of function is:

function testUncompilable() {
  // It's not totally clear how a module loader should perform with unusable
  // modules, however at least it should go into a flat spin ...
  // GCLI mini_require reports an error as it should
  try {
    let unrequireable = require('gclitest/unrequirable');
    fail();
  }
  catch (ex) {
    // expected
  }
}
Comment 2 Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-08-05 04:35:12 PDT
Created attachment 551001 [details] [diff] [review]
[in-fx-team] upload 1

This also fixes to indentation errors in the same function
Comment 3 Rob Campbell [:rc] (:robcee) 2011-08-05 06:01:57 PDT
Comment on attachment 551001 [details] [diff] [review]
[in-fx-team] upload 1

http://hg.mozilla.org/integration/fx-team/rev/4ec2052b0839
Comment 4 Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-08-05 07:52:57 PDT
Yeay. Thanks Rob.
Comment 5 Tim Taubert [:ttaubert] 2011-08-07 11:27:06 PDT
http://hg.mozilla.org/mozilla-central/rev/4ec2052b0839

Note You need to log in before you can comment on or make changes to this bug.