The default bug view has changed. See this FAQ.

GCLI requirejs tests log when they shouldn't

RESOLVED FIXED in Firefox 8

Status

()

Firefox
Developer Tools
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jwalker, Assigned: jwalker)

Tracking

unspecified
Firefox 8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

testUncompilable() shouldn't console.log()
Correct definition of function is:

function testUncompilable() {
  // It's not totally clear how a module loader should perform with unusable
  // modules, however at least it should go into a flat spin ...
  // GCLI mini_require reports an error as it should
  try {
    let unrequireable = require('gclitest/unrequirable');
    fail();
  }
  catch (ex) {
    // expected
  }
}
Assignee: nobody → jwalker
Created attachment 551001 [details] [diff] [review]
[in-fx-team] upload 1

This also fixes to indentation errors in the same function
Attachment #551001 - Flags: review+
Comment on attachment 551001 [details] [diff] [review]
[in-fx-team] upload 1

http://hg.mozilla.org/integration/fx-team/rev/4ec2052b0839
Attachment #551001 - Attachment description: upload 1 → [in-fx-team] upload 1
Whiteboard: [fixed-in-fx-team]
Yeay. Thanks Rob.
http://hg.mozilla.org/mozilla-central/rev/4ec2052b0839
Status: NEW → RESOLVED
Last Resolved: 6 years ago
OS: Windows 7 → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 8

Updated

6 years ago
Depends on: 677996

Updated

6 years ago
No longer depends on: 677996
You need to log in before you can comment on or make changes to this bug.