676556 - GCLI requirejs tests log when they shouldn't

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Joe Walker [:jwalker]]

testUncompilable() shouldn't console.log()

Comment 1

[Joe Walker [:jwalker]]

Correct definition of function is:

function testUncompilable() {
  // It's not totally clear how a module loader should perform with unusable
  // modules, however at least it should go into a flat spin ...
  // GCLI mini_require reports an error as it should
  try {
    let unrequireable = require('gclitest/unrequirable');
    fail();
  }
  catch (ex) {
    // expected
  }
}

Comment 2

[Joe Walker [:jwalker]]

Attachment: [in-fx-team] upload 1

This also fixes to indentation errors in the same function

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 551001 [details] [diff] [review]
[in-fx-team] upload 1

http://hg.mozilla.org/integration/fx-team/rev/4ec2052b0839

Comment 4

[Joe Walker [:jwalker]]

Yeay. Thanks Rob.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

http://hg.mozilla.org/mozilla-central/rev/4ec2052b0839