Last Comment Bug 676803 - Thumbnails are not generated for hidden tabs in stacked groups
: Thumbnails are not generated for hidden tabs in stacked groups
: regression
Product: Firefox Graveyard
Classification: Graveyard
Component: Panorama (show other bugs)
: Trunk
: All All
-- normal
: ---
Assigned To: Tim Taubert [:ttaubert]
Depends on:
Blocks: 606148
  Show dependency treegraph
Reported: 2011-08-05 05:28 PDT by Tim Taubert [:ttaubert]
Modified: 2016-04-12 14:00 PDT (History)
1 user (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---

patch v1 (6.35 KB, patch)
2011-08-05 09:16 PDT, Tim Taubert [:ttaubert]
dietrich: review+
Details | Diff | Splinter Review

Description User image Tim Taubert [:ttaubert] 2011-08-05 05:28:47 PDT
When a tab is added to an already stacked group that contains at least six tabItems then we'll never generate a thumbnail for this tab. If we now restart the browser, open panorama and expand the group every tabItem with indexInGroup > 5 has no thumbnail.
Comment 1 User image Tim Taubert [:ttaubert] 2011-08-05 09:16:22 PDT
Created attachment 551057 [details] [diff] [review]
patch v1

1) setBounds() is now also called for hidden tabItems when stack-arranging a group. This is essential for the thumbnails to have the right size.

2) Changed .tabHidden css from "display:none" to "visibility:hidden" so that a tabItem's canvas is actually rendered in the background and can be drawn to.
Comment 2 User image Dietrich Ayala (:dietrich) 2011-08-22 15:33:53 PDT
Comment on attachment 551057 [details] [diff] [review]
patch v1

Review of attachment 551057 [details] [diff] [review]:

r=me. the only concern i have is that with big sessions we'll be rendering hundreds of canvases now that we weren't before, for the lifetime of the application. can you do a measurement of a large session to see if there's any detectable memory increase with this pach?
Comment 3 User image Tim Taubert [:ttaubert] 2012-04-23 05:56:28 PDT
Fixed by bug 745303.

Note You need to log in before you can comment on or make changes to this bug.