Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Thumbnails are not generated for hidden tabs in stacked groups

RESOLVED FIXED

Status

Firefox Graveyard
Panorama
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

({regression})

Trunk
regression

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
When a tab is added to an already stacked group that contains at least six tabItems then we'll never generate a thumbnail for this tab. If we now restart the browser, open panorama and expand the group every tabItem with indexInGroup > 5 has no thumbnail.
(Assignee)

Comment 1

6 years ago
Created attachment 551057 [details] [diff] [review]
patch v1

1) setBounds() is now also called for hidden tabItems when stack-arranging a group. This is essential for the thumbnails to have the right size.

2) Changed .tabHidden css from "display:none" to "visibility:hidden" so that a tabItem's canvas is actually rendered in the background and can be drawn to.
Attachment #551057 - Flags: review?(dietrich)
Comment on attachment 551057 [details] [diff] [review]
patch v1

Review of attachment 551057 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. the only concern i have is that with big sessions we'll be rendering hundreds of canvases now that we weren't before, for the lifetime of the application. can you do a measurement of a large session to see if there's any detectable memory increase with this pach?
Attachment #551057 - Flags: review?(dietrich) → review+
(Assignee)

Comment 3

5 years ago
Fixed by bug 745303.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.