676836 - Remove code duplication for print menus by moving them to utilityOverlay

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Ian Neal]

Attachment: Centralise print menus [Checked in: Comment 4]

For the Print, Print Preview and Page Setup menu items we have a certain amount of code duplication across suite, this can be reduced by centralising the code into utilityOverlay.
This patch does that by:
* Creating key_print, menu_print, menu_printSetup and menu_printPreview overlays.
* Adding relevant entities to utilityOverlay.dtd
* Tweaking command elements where relevant.
* Removing now unused entities from other dtd files.

Comment 1

[[e-mail]]

Comment on attachment 551038 [details] [diff] [review]
Centralise print menus [Checked in: Comment 4]

I take it the entities you've left behind in the editor, navigator and mail windows are the ones used by the print button dropdown?

Comment 2

[Ian Neal]

(In reply to [e-mail] from comment #1)
> Comment on attachment 551038 [details] [diff] [review] [diff] [details] [review]
> Centralise print menus
> 
> I take it the entities you've left behind in the editor, navigator and mail
> windows are the ones used by the print button dropdown?

Correct, they'll be removed in bug 676991

Comment 3

[Ian Neal]

Comment on attachment 551038 [details] [diff] [review]
Centralise print menus [Checked in: Comment 4]

Requesting additional review for the editorOverlay.dtd changes as it is a shared file.

Comment 4

[Ian Neal]

Comment on attachment 551038 [details] [diff] [review]
Centralise print menus [Checked in: Comment 4]

http://hg.mozilla.org/comm-central/rev/400d40dac19b