Remove code duplication for print menus by moving them to utilityOverlay

RESOLVED FIXED in seamonkey2.5

Status

SeaMonkey
UI Design
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

Trunk
seamonkey2.5
Dependency tree / graph
Bug Flags:
in-testsuite -

SeaMonkey Tracking Flags

(seamonkey2.5 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 551038 [details] [diff] [review]
Centralise print menus [Checked in: Comment 4]

For the Print, Print Preview and Page Setup menu items we have a certain amount of code duplication across suite, this can be reduced by centralising the code into utilityOverlay.
This patch does that by:
* Creating key_print, menu_print, menu_printSetup and menu_printPreview overlays.
* Adding relevant entities to utilityOverlay.dtd
* Tweaking command elements where relevant.
* Removing now unused entities from other dtd files.
Attachment #551038 - Flags: review?(neil)

Comment 1

6 years ago
Comment on attachment 551038 [details] [diff] [review]
Centralise print menus [Checked in: Comment 4]

I take it the entities you've left behind in the editor, navigator and mail windows are the ones used by the print button dropdown?
(Assignee)

Updated

6 years ago
Depends on: 676985
(Assignee)

Updated

6 years ago
Blocks: 676991
(Assignee)

Comment 2

6 years ago
(In reply to neil@parkwaycc.co.uk from comment #1)
> Comment on attachment 551038 [details] [diff] [review] [diff] [details] [review]
> Centralise print menus
> 
> I take it the entities you've left behind in the editor, navigator and mail
> windows are the ones used by the print button dropdown?

Correct, they'll be removed in bug 676991

Updated

6 years ago
Attachment #551038 - Flags: review?(neil) → review+
(Assignee)

Comment 3

6 years ago
Comment on attachment 551038 [details] [diff] [review]
Centralise print menus [Checked in: Comment 4]

Requesting additional review for the editorOverlay.dtd changes as it is a shared file.
Attachment #551038 - Flags: review?(mbanner)
Attachment #551038 - Flags: review?(mbanner) → review+
(Assignee)

Comment 4

6 years ago
Comment on attachment 551038 [details] [diff] [review]
Centralise print menus [Checked in: Comment 4]

http://hg.mozilla.org/comm-central/rev/400d40dac19b
Attachment #551038 - Attachment description: Centralise print menus → Centralise print menus [Checked in: Comment 4]
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
status-seamonkey2.5: --- → fixed
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.5
(Assignee)

Updated

6 years ago
Blocks: 688970
You need to log in before you can comment on or make changes to this bug.