Closed Bug 688970 Opened 14 years ago Closed 14 years ago

Fix hiding of print preview menus on OS X

Categories

(SeaMonkey :: General, defect)

Product:
SeaMonkey
Component:
General
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.3 unaffected, seamonkey2.4 unaffected, seamonkey2.5 fixed, seamonkey2.6 fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.6
Tracking Flags:
Tracking Status
seamonkey2.3 --- unaffected
seamonkey2.4 --- unaffected
seamonkey2.5 --- fixed
seamonkey2.6 --- fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

Details

(Keywords: regression)

Attachments

(1 file)

Hide printpreview on OS X [Checked in: trunk Comment 2 & comm-aurora Comment 5]
857 bytes, patch
neil
: review+
Callek
: approval-comm-aurora+
Details | Diff | Splinter Review
Since landing of bug 21432 and bug 676836 some print preview menus show on OS X which shouldn't.
Attachment #562236 - Flags: review?(neil)
Comment on attachment 562236 [details] [diff] [review] Hide printpreview on OS X [Checked in: trunk Comment 2 & comm-aurora Comment 5] > <menuitem id="printPreviewMenuItem" hidden="true"/> Will this be going away soon?
Attachment #562236 - Flags: review?(neil) → review+
Comment on attachment 562236 [details] [diff] [review] Hide printpreview on OS X [Checked in: trunk Comment 2 & comm-aurora Comment 5] http://hg.mozilla.org/comm-central/rev/c90f8e86b3c2
Attachment #562236 - Attachment description: Hide printpreview on OS X → Hide printpreview on OS X [Checked in: Comment 2]
(In reply to neil@parkwaycc.co.uk from comment #1) > Comment on attachment 562236 [details] [diff] [review] [diff] [details] [review] > Hide printpreview on OS X [Checked in: Comment 2] > > > <menuitem id="printPreviewMenuItem" hidden="true"/> > Will this be going away soon? Well addressbook needs it as utilityOverlay.xul is overlaying addressbook.xul
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
status-seamonkey2.3: --- → unaffected
status-seamonkey2.4: --- → unaffected
status-seamonkey2.5: --- → affected
status-seamonkey2.6: --- → fixed
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.6
Comment on attachment 562236 [details] [diff] [review] Hide printpreview on OS X [Checked in: trunk Comment 2 & comm-aurora Comment 5] As bug 676836 landed on SM2.5, requesting approval for comm-aurora
Attachment #562236 - Flags: approval-comm-aurora?
Attachment #562236 - Flags: approval-comm-aurora? → approval-comm-aurora+
Comment on attachment 562236 [details] [diff] [review] Hide printpreview on OS X [Checked in: trunk Comment 2 & comm-aurora Comment 5] http://hg.mozilla.org/releases/comm-aurora/rev/4bc1aa261198
Attachment #562236 - Attachment description: Hide printpreview on OS X [Checked in: Comment 2] → Hide printpreview on OS X [Checked in: trunk Comment 2 & comm-aurora Comment 5]
status-seamonkey2.5: affected → fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: