676965 - xpcshell test js/src/xpconnect/tests/unit/test_localeCompare.js fails on Android

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Geoff Brown [:gbrown]]

With patches for bug 668349 and 668351, xpcshell tests can be run on an Android device, and the majority of tests pass. 

However, js/src/xpconnect/tests/unit/test_localeCompare.js consistently fails when run on Android.

Comment 1

[Geoff Brown [:gbrown]]

make: Entering directory `/home/geoff/src/mozilla-central/objdir-droid/js/src/xpconnect/tests'
/usr/bin/python2.6 -u ../../../../../config/pythonpath.py \
	  -I../../../../../build \
	  -I../../../../../build/mobile \
	  ../../../../../testing/xpcshell/remotexpcshelltests.py \
	  --symbols-path=../../../../dist/crashreporter-symbols \
	  --build-info-json=../../../../mozinfo.json \
	  --test-path=test_localeCompare.js \
	  --profile-name=fennec \
	  --verbose \
	   \
	  --dm_trans=adb \
	  --deviceIP= \
	  --objdir=../../../.. \
          --noSetup \
	  ../../../../_tests/xpcshell/js/src/xpconnect/tests/unit
208 KB/s (13656 bytes in 0.063s)
will execute commands via run-as org.mozilla.fennec_geoff
using APK: ../../../../dist/fennec-9.0a1.en-US.eabi-arm.apk
chmod /data/local/tests/xpcshell/p
TEST-INFO | profile dir is /data/local/tests/xpcshell/p
TEST-INFO | /home/geoff/src/mozilla-central/objdir-droid/_tests/xpcshell/js/src/xpconnect/tests/unit/test_localeCompare.js | running test ...
cd /data/local/tests/xpcshell/js/src/xpconnect/tests/unit; LD_LIBRARY_PATH=/data/local/tests/xpcshell/b; export CACHE_PATH=/data/local/tests/xpcshell/b; export GRE_HOME=/data/data/org.mozilla.fennec_geoff; export XPCSHELL_TEST_PROFILE_DIR=/data/local/tests/xpcshell/p; /data/local/tests/xpcshell/b/xpcshell -r /data/local/tests/xpcshell/c/httpd.manifest --greomni /data/local/tests/xpcshell/b/fennec-9.0a1.en-US.eabi-arm.apk -j -s -e 'const _HTTPD_JS_PATH = "/data/local/tests/xpcshell/c/httpd.js";' -e 'const _HEAD_JS_PATH = "/data/local/tests/xpcshell/head.js";' -f /data/local/tests/xpcshell/head.js -e 'const _SERVER_ADDR = "localhost"' -e 'const _HEAD_FILES = [];' -e 'const _TAIL_FILES = [];' -e 'const _TEST_FILE = ["test_localeCompare.js"];' -e '_execute_test(); quit(0);'
TEST-UNEXPECTED-FAIL | /home/geoff/src/mozilla-central/objdir-droid/_tests/xpcshell/js/src/xpconnect/tests/unit/test_localeCompare.js | test failed (with xpcshell return code: 0), see following log:
>>>>>>>

TEST-INFO | (xpcshell/head.js) | test 1 pending

TEST-PASS | test_localeCompare.js | [run_test : 2] true == true

TEST-PASS | test_localeCompare.js | [run_test : 3] true == true

TEST-UNEXPECTED-FAIL | test_localeCompare.js | false == true - See following stack:
JS frame :: /data/local/tests/xpcshell/head.js :: do_throw :: line 445
JS frame :: /data/local/tests/xpcshell/head.js :: _do_check_eq :: line 539
JS frame :: /data/local/tests/xpcshell/head.js :: do_check_eq :: line 560
JS frame :: /data/local/tests/xpcshell/head.js :: do_check_true :: line 574
JS frame :: test_localeCompare.js :: run_test :: line 4
JS frame :: /data/local/tests/xpcshell/head.js :: _execute_test :: line 326
JS frame :: -e :: <TOP_LEVEL> :: line 1

TEST-INFO | (xpcshell/head.js) | exiting test
<<<<<<<
INFO | Result summary:
INFO | Passed: 0
INFO | Failed: 1
INFO | Todo: 0
make: *** [check-one-remote] Error 1
make: Leaving directory `/home/geoff/src/mozilla-central/objdir-droid/js/src/xpconnect/tests'

Comment 2

[Geoff Brown [:gbrown]]

It looks like the failure is at:

do_check_true("\u010C".localeCompare("D") < 0);

Comment 3

[Makoto Kato [:m_kato]]

I turn off this test by bug 1347431, but since we have land ICU on all channel, we can turn on this.

Comment 4

[Makoto Kato [:m_kato]]

Attachment: Bug 676965 - Turn on test_localeCompare.js on Android since we use ICU.

We should turn on test_localeCompare.js again on Android since we use ICU.

Review commit: https://reviewboard.mozilla.org/r/164256/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/164256/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1db95737d866
Turn on test_localeCompare.js on Android since we use ICU. r=gandalf

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1db95737d866