677026 - nsIDOMWindow should inherit nsIDOMEventTarget

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

http://html5.org/tools/web-apps-tracker?from=6377&to=6378

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Grr, tbox doesn't like the patch.
Seems like nsIDOMWindow.idl can't find nsIDOMEventTarget.idl

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: move nsIDOMEventTarget from dom/interfaces/events to dom/intefaces/base

So DOMWindow needs to find DOMEventTarget. Either interfaces/events needs to
be processed before interfaces/base, and interfaces/events must not
refer to anything in interfaces/base (like domstubs), or we just move
this one interface to base/.
This is the easiest fix I could find: move nsIDOMEventTarget (which is becoming a
kind of base interface for many DOM interfaces) to base/.

I didn't notice this problem earlier, since it happens only with clobber builds.

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I think you can just add 'XPIDL_FLAGS += -I$(topsrcdir)/dom/interfaces/events' in dom/interfaces/base's Makefile.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Testing that...

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Attachment: XPIDL_FLAGS

Ok, this works.
Who would new about XPIDL_FLAGS. It is used so rarely.

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to Olli Pettay [:smaug] from comment #6)
> Who would new about XPIDL_FLAGS. It is used so rarely.

The guy who hacks on the IDL compiler? ;-)

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

(In reply to Olli Pettay [:smaug] from comment #6)
> Who would new about XPIDL_FLAGS. It is used so rarely.
'new'? Huh, how did I type that.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/e6e47912000d

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Still no good. About to back out.

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/b422fd99fe0d

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

Attachment: +fixes to tests and a change to nsHelperAppDlg.js to allow null context

Comment 13

[Andrew McCreight [:mccr8]]

Should this be resolved fixed?  From comment 11, it looks like it relanded and wasn't backed out.

Comment 14

[Olli Pettay [:smaug][[e-mail]]]

This isn't in the tree.

Comment 15

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Might be this also needs to change nsWindowSH::InstallGlobalScopePolluter; I don't think we want EventTarget to inherit from the gsp.

Comment 16

[Boris Zbarsky [:bzbarsky]]

That's correct.  Per WebIDL, the proto chain should look like this:

  window object -> Window.prototype -> GSP -> EventTarget.prototype -> Object.prototype

Comment 17

[Boris Zbarsky [:bzbarsky]]

nsIDOMEventTarget is gone.  nsIDOMWindow will go away too, at some point.