Closed
Bug 1429903
Opened 8 years ago
Closed 8 years ago
Remove nsIDOMEventTarget
Categories
(Core :: DOM: Core & HTML, enhancement, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
|
5.98 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
|
43.69 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
|
37.65 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
|
29.54 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
Can do once bug 888591 is fixed.
|
||
Updated•8 years ago
|
Priority: -- → P3
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → bzbarsky
|
|
Assignee | |
Comment 1•8 years ago
|
||
MozReview-Commit-ID: Ak0xdxxnSbI
Attachment #8969252 -
Flags: review?(continuation)
|
|
Assignee | |
Comment 2•8 years ago
|
||
MozReview-Commit-ID: HQw7TyJUapY
Attachment #8969253 -
Flags: review?(continuation)
|
|
Assignee | |
Comment 3•8 years ago
|
||
MozReview-Commit-ID: 4NdssvnWn0H
Attachment #8969254 -
Flags: review?(continuation)
|
|
Assignee | |
Comment 4•8 years ago
|
||
MozReview-Commit-ID: 9XuenUHxfPx
Attachment #8969255 -
Flags: review?(continuation)
|
||
Updated•8 years ago
|
Attachment #8969252 -
Flags: review?(continuation) → review+
|
|
||
Comment 5•8 years ago
|
||
Comment on attachment 8969253 [details] [diff] [review]
part 2. Stop using nsIDOMEventTarget in xpidl
Review of attachment 8969253 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/components/sessionstore/nsISessionStoreUtils.idl
@@ +43,5 @@
> *
> * This is implemented as a native filter, rather than a JS-based one, for
> * performance reasons.
> *
> * Once bug 1444991 is fixed, this should start taking an EventTarget.
nit: you can remove this comment.
Attachment #8969253 -
Flags: review?(continuation) → review+
|
|
Assignee | |
Comment 6•8 years ago
|
||
> nit: you can remove this comment.
Good catch, fixed.
|
|
||
Updated•8 years ago
|
Attachment #8969254 -
Flags: review?(continuation) → review+
|
|
||
Comment 7•8 years ago
|
||
Comment on attachment 8969255 [details] [diff] [review]
part 4. Remove nsIDOMEventTarget
Review of attachment 8969255 [details] [diff] [review]:
-----------------------------------------------------------------
Nice.
Attachment #8969255 -
Flags: review?(continuation) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b18a3c2beaf
part 1. Remove various target getters on nsIDOMEvent. r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/706b6ff8ea85
part 2. Stop using nsIDOMEventTarget in xpidl. r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/d03756b18579
part 3. Remove C++ uses of nsIDOMEventTarget. r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/36f208401c87
part 4. Remove nsIDOMEventTarget. r=mccr8
|
|
||
Comment 9•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8b18a3c2beaf
https://hg.mozilla.org/mozilla-central/rev/706b6ff8ea85
https://hg.mozilla.org/mozilla-central/rev/d03756b18579
https://hg.mozilla.org/mozilla-central/rev/36f208401c87
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
|
||
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•