Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
4 months ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

(Blocks 1 bug)

unspecified
mozilla61
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(4 attachments)

Can do once bug 888591 is fixed.
Blocks: 705541
Blocks: 677026
Priority: -- → P3
Depends on: 1444991
Depends on: 1449631
Depends on: 1450418
Depends on: 1450421
Depends on: 1450422
Assignee: nobody → bzbarsky
Depends on: 1455055
MozReview-Commit-ID: Ak0xdxxnSbI
Attachment #8969252 - Flags: review?(continuation)
MozReview-Commit-ID: HQw7TyJUapY
Attachment #8969253 - Flags: review?(continuation)
MozReview-Commit-ID: 4NdssvnWn0H
Attachment #8969254 - Flags: review?(continuation)
MozReview-Commit-ID: 9XuenUHxfPx
Attachment #8969255 - Flags: review?(continuation)
Attachment #8969252 - Flags: review?(continuation) → review+
Comment on attachment 8969253 [details] [diff] [review]
part 2.  Stop using nsIDOMEventTarget in xpidl

Review of attachment 8969253 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/sessionstore/nsISessionStoreUtils.idl
@@ +43,5 @@
>     *
>     * This is implemented as a native filter, rather than a JS-based one, for
>     * performance reasons.
>     *
>     * Once bug 1444991 is fixed, this should start taking an EventTarget.

nit: you can remove this comment.
Attachment #8969253 - Flags: review?(continuation) → review+
> nit: you can remove this comment.

Good catch, fixed.
Attachment #8969254 - Flags: review?(continuation) → review+
Comment on attachment 8969255 [details] [diff] [review]
part 4.  Remove nsIDOMEventTarget

Review of attachment 8969255 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #8969255 - Flags: review?(continuation) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b18a3c2beaf
part 1.  Remove various target getters on nsIDOMEvent.  r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/706b6ff8ea85
part 2.  Stop using nsIDOMEventTarget in xpidl.  r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/d03756b18579
part 3.  Remove C++ uses of nsIDOMEventTarget.  r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/36f208401c87
part 4.  Remove nsIDOMEventTarget.  r=mccr8
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.