677044 - GIF animation drops all frames after a certain point

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Matthew Turnbull [Bluefang]]

Attachment: example GIF affected by this issue

Some GIF images drop all frames after a certain point, causing them to restart prematurely.

The regression range looks to be:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=be4b064f1159&tochange=5684f06138f3

From that list, the likely culprit is Bug 609499

Comment 1

[Daniel Holbert [:dholbert]]

Confirming.
EXPECTED RESULTS: Chair spins, camera pans up/left to a woman's face.
ACTUAL RESULTS:  Chair only spins partway, & animation abruptly restarts.

Firefox 5 shows EXPECTED RESULTS. Nightly shows ACTUAL RESULTS. (Nightly never gets to the part of the animation with the woman's face)

Mozilla/5.0 (X11; Linux i686; rv:8.0a1) Gecko/20110806 Firefox/8.0a1

Comment 2

[Fanolian]

It's happening on Windows platform (win7 at least) also.

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0a1) Gecko/20110806 Firefox/8.0a1

Comment 4

[Thomas Ahlblom]

Local track down using Linux x86_64:

The first bad revision is:
changeset:   73789:67044ea27b53
user:        Joe Drew <[e-mail]>
date:        Wed Aug 03 15:19:19 2011 -0400
summary:     Bug 609499 - Some invalid GIF files don't terminate their LZW data with a 0-length block. Handle them better by handling them less specially. r=jrmuizel

http://hg.mozilla.org/mozilla-central/rev/67044ea27b53

Comment 5

[Daniel Holbert [:dholbert]]

Attachment: testcase 2 (should show 2 people colliding)

Here's another affected gif.  Should show 2 people colliding, but Nightly just shows just a few frames of one person running at the beginning.
(source: http://www.reddit.com/r/funny/comments/jjr70/smoosh/ )

Comment 6

[Stefan]

Attachment: testcase, shall rotate around z axis, does not rotate

Comment 9

[NightsoN Blaze]

Another affected gif:http://i.imgur.com/Yg5za.gif

Comment 11

[Boris Zbarsky [:bzbarsky]]

joe, jeff, could you please take a look at this?  We need to figure out whether we fix this or back out bug 609499 on Aurora, imo.

Comment 12

[Jeff Muizelaar [:jrmuizel]]

I've backed out 67044ea27b53 from FF8 (Aurora) and FF9 (Central):
http://hg.mozilla.org/mozilla-central/rev/d2cd9f583b0a
http://hg.mozilla.org/releases/mozilla-aurora/rev/b747b6535a03

Comment 13

[[e-mail]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #12)
> I've backed out 67044ea27b53 from FF8 (Aurora) and FF9 (Central):
> http://hg.mozilla.org/mozilla-central/rev/d2cd9f583b0a
> http://hg.mozilla.org/releases/mozilla-aurora/rev/b747b6535a03

That's fixed it, it seems

Comment 14

[Hideo Oshima]

Why is this bug still open?
I think it can be marked as FIXED or WORKSFORME.

Comment 15

[Scott Johnson (:jwir3)]

Since bug 609499 was backed out, this is no longer an issue.

Comment 17

[u279076]

qa+ for verification using the attached testcase in comment 0.

Comment 18

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/2200774c8d49

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/releases/mozilla-release/rev/6eb75a6f3c1d
Back out b38381eb91b8 (crashtest for bug 609499, which was backed out)