GIF animation drops all frames after a certain point

RESOLVED FIXED

Status

()

Core
ImageLib
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Matthew Turnbull [Bluefang], Unassigned)

Tracking

({regression, testcase})

Trunk
regression, testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox8+ unaffected, firefox9 unaffected)

Details

(Whiteboard: [fixed by backout of bug 609499][qa+])

Attachments

(3 attachments)

(Reporter)

Description

6 years ago
Created attachment 551279 [details]
example GIF affected by this issue

Some GIF images drop all frames after a certain point, causing them to restart prematurely.

The regression range looks to be:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=be4b064f1159&tochange=5684f06138f3

From that list, the likely culprit is Bug 609499
Confirming.
EXPECTED RESULTS: Chair spins, camera pans up/left to a woman's face.
ACTUAL RESULTS:  Chair only spins partway, & animation abruptly restarts.

Firefox 5 shows EXPECTED RESULTS. Nightly shows ACTUAL RESULTS. (Nightly never gets to the part of the animation with the woman's face)

Mozilla/5.0 (X11; Linux i686; rv:8.0a1) Gecko/20110806 Firefox/8.0a1
Keywords: regression, testcase
Hardware: x86_64 → All
Version: Trunk → Other Branch
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: Other Branch → Trunk
Blocks: 609499

Comment 2

6 years ago
It's happening on Windows platform (win7 at least) also.

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0a1) Gecko/20110806 Firefox/8.0a1
OS: Linux → All
tracking-firefox8: --- → ?

Updated

6 years ago
Duplicate of this bug: 678746

Comment 4

6 years ago
Local track down using Linux x86_64:

The first bad revision is:
changeset:   73789:67044ea27b53
user:        Joe Drew <joe@drew.ca>
date:        Wed Aug 03 15:19:19 2011 -0400
summary:     Bug 609499 - Some invalid GIF files don't terminate their LZW data with a 0-length block. Handle them better by handling them less specially. r=jrmuizel

http://hg.mozilla.org/mozilla-central/rev/67044ea27b53
Created attachment 553375 [details]
testcase 2 (should show 2 people colliding)

Here's another affected gif.  Should show 2 people colliding, but Nightly just shows just a few frames of one person running at the beginning.
(source: http://www.reddit.com/r/funny/comments/jjr70/smoosh/ )

Comment 6

6 years ago
Created attachment 553725 [details]
testcase, shall rotate around z axis, does not rotate

Updated

6 years ago
Duplicate of this bug: 680437

Updated

6 years ago
Duplicate of this bug: 680775

Comment 9

6 years ago
Another affected gif:http://i.imgur.com/Yg5za.gif
Blocks: 679587

Updated

6 years ago
Duplicate of this bug: 682223
joe, jeff, could you please take a look at this?  We need to figure out whether we fix this or back out bug 609499 on Aurora, imo.
I've backed out 67044ea27b53 from FF8 (Aurora) and FF9 (Central):
http://hg.mozilla.org/mozilla-central/rev/d2cd9f583b0a
http://hg.mozilla.org/releases/mozilla-aurora/rev/b747b6535a03

Comment 13

6 years ago
(In reply to Jeff Muizelaar [:jrmuizel] from comment #12)
> I've backed out 67044ea27b53 from FF8 (Aurora) and FF9 (Central):
> http://hg.mozilla.org/mozilla-central/rev/d2cd9f583b0a
> http://hg.mozilla.org/releases/mozilla-aurora/rev/b747b6535a03

That's fixed it, it seems

Updated

6 years ago
status-firefox8: --- → unaffected
tracking-firefox8: ? → +

Updated

6 years ago
status-firefox9: --- → unaffected

Comment 14

6 years ago
Why is this bug still open?
I think it can be marked as FIXED or WORKSFORME.
Since bug 609499 was backed out, this is no longer an issue.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Duplicate of this bug: 679587
Whiteboard: [fixed by backout of bug 609499]
qa+ for verification using the attached testcase in comment 0.
Whiteboard: [fixed by backout of bug 609499] → [fixed by backout of bug 609499][qa+]
You need to log in before you can comment on or make changes to this bug.