677049 - Contents of preference window doesn't fit window size

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[Michael Jonker]

Attachment: Screenshot of pref-window

Firefox 5.0.1 + Chatzilla 0.9.87 (on Mac OSX 10.6.8)

Open the preference pane of Chatzilla. (In Firefox select the Tools menu and click "Addons". Find Chatzilla in the list and click the "Preferences"-button.

The contents of the preference-window doesn't fit the window size. And the window is not resizable so its impossible to make the window bigger to accommodate the contents.

I've included a screenshot to demonstrate what I'm seeing.

Comment 1

[James Ross]

Alas the lack of resizing is a Firefox requirement (open the preferences from ChatZilla, /cmd-prefs, and they are resizable). The width problem is Mac's theme for tabs is massively wider than any other platform. :(

We actually already make the window winder on Mac, too. Guess it needs bumping.

Comment 2

[Michael Jonker]

Hmmm, its a pity that the width of tabs on Mac is so different. Anyway, your suggestion of using /cmd-prefs is very helpful since I hadn't noticed that method of getting to the preferences and be able to resize the window.

It might be an idea to create a new menu-entry "Preferences" under the Chatzilla-menu which will execute the /cmd-prefs command. That way users will be presented with a resizable preference-pane. 

Another solution is doing a redesign of the whole window but that may be a bit too much for solving this.

Comment 3

[James Ross]

We actually have a Preferences item under the ChatZilla menu on non-Mac platforms; on Mac, we ask Firefox to redirect the Firefox > Preferences menu to ours (I admit that's not entirely intuative either) but Firefox 4 managed to break this so there's no menu access at all IIRC. :(

In bug 608663, we're putting the menu back on Mac to where it is on non-Mac, exactly as you suggest.

I don't suppose you have a way to measure how much you needed to expand the window before everything fits without being cut-off?

Comment 4

[Michael Jonker]

I read bug 608663 in a search trying to prevent reporting a duplicate :-)

And I did manage to measure the original window and the resized one:

Original: 640x480
Resized : 710x480 (which fits all the tabs)

Comment 5

[James Ross]

I've had a thought; have you checked the preferences window from within ChatZilla (/cmd-prefs)? I've just got a funny feeling this problem may be specific to opening it from about:addons.

Comment 6

[Michael Jonker]

If I open the preference window with /cmd-prefs from within Chatzilla I get the prefs-window just like in https://bugzilla.mozilla.org/attachment.cgi?id=551287 with one difference: I can resize the window.

So to summerise: 
Open the prefs window from about:addons -> window is too small; window not resizable.
Open the prefs window with /cmd-prefs in Chatzilla -> window is too small; window is resizable.

Comment 7

[James Ross]

Attachment: Enlarge Mac-specific preferences window further

Okay, in that case here's a patch that combines the existing width enlargement with the different in your reported window sizes. It'd be nice if you could test it, but I'm not sure how familiar you are with editing extensions.

Comment 8

[James Ross]

http://hg.mozilla.org/chatzilla/rev/1e19de74d62c