677170 - Convert .button-link (buttons that look like links) to look like actual buttons

Status: RESOLVED INACTIVE

(Toolkit :: Add-ons Manager, defect)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

There's a few buttons that look like links, but really act like buttons (of class .button-link). This is inconstant, and goes against expectations of how they should act. They should be converted to look like actual buttons.

This includes buttons in:
* Global update
* Global notifications
* 'More' button (already covered by bug 625465)

Comment 1

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Also:
* Addons pending uninstall
* Addon that failed install
* Other per-addon notifications
* Update check from details view

And the plugin check link also uses that class, but it does actually behave (to the user) like a link. However... code wise, it doesn't figure out what the URL is until it's clicked. That needs changed for bug 603236 to be fixed anyway.

Comment 2

[Dave Townsend [:mossop]]

Please get ui-review on this before requesting review.

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: WiP Patch v1

Work in progress. Think I've converted everything. Patch goes on top of the patch in bug 646713, as the buttons are a lighter-feeling version of the new style in that bug. But it needs some work - shorlander is pondering on how to make these buttons feel less busy.

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: WiP v1 screenshot

Screenshot with current patch applied (on top of patches from bug 646713 and bug 630682). Ignore the big "More" button, that goes away in bug 625465.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 565126 [details]
WiP v1 screenshot

Is it expected to have rounded corners for the "Restart Now" and "Undo" buttons? Also why are those links act as buttons? I can agree for both buttons mentioned above, but what about "More"? This one really feels like a link, because it opens a new page. Shouldn't we better leave this as a link?

Comment 6

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to Henrik Skupin (:whimboo) from comment #5)
> Is it expected to have rounded corners for the "Restart Now" and "Undo"
> buttons?

Maybe - that screenshot is an experiment in making them feel not so heavy, so the UI doesn't feel as busy. Hoping shorlander and I can come up with something better.

> Also why are those links act as buttons? 

Because that's how it was originally designed, but since they act like buttons they should look like buttons. Thus this bug :)

> but what about "More"? This one really feels like a
> link, because it opens a new page. Shouldn't we better leave this as a link?

Bug 625465 will make that "More" button into an arrow, and make is a lot more subtle. See bug 625465 for rationale and mockups. I'll need to either have bug 625465 fixed, or make that button not so bug/obvious, for this to land (it could probably have the new light-weight button style as a temporary solution).

Comment 7

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.