677259 - Site panel's text is white colored for Gingerbread theme

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Cristian Nicolae (:xti)]

Attachment: screenshot

Build id : Mozilla/5.0 (Android;Linux armv7l;rv:8.0a1)Gecko/20110808
Firefox/8.0a1 Fennec/8.0a1
Device: HTC Desire Z
OS: Android 2.3.3

Due to bug 659457, the site panel's text should be black for Gingerbread theme, but actually is white colored as you can see in the attached screenshot.

Comment 1

[Aaron Train [:aaronmt]]

Mock-up: http://www.flickr.com/photos/61892693@N03/5726890406/in/set-72157626609900587

Comment 2

[Aaron Train [:aaronmt]]

Attachment: Patch v1 (inverse text color)

+ color: @color_text_inverse@;

Comment 3

[Aaron Train [:aaronmt]]

Attachment: Patch v1 (inverse text color)

wrong commit message

Comment 4

[Aaron Train [:aaronmt]]

Attachment: Patch v1 (inverse text color)

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 551766 [details] [diff] [review]
Patch v1 (inverse text color)

This would work, but I don't think we want to tie this to color_text_inverse. Since the background has a specific name, we'll make a new named color for the text too: color_text_panel

Can you add color_text_panel to gingerbread/defines.inc and use it here?

Comment 6

[Aaron Train [:aaronmt]]

Attachment: Patch v1.1 - (color_text_panel)

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/4750c8153a55

Comment 8

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/4750c8153a55