Closed Bug 677259 Opened 8 years ago Closed 8 years ago

Site panel's text is white colored for Gingerbread theme

Categories

(Firefox for Android Graveyard :: General, defect, P2)

ARM
Android
defect

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 8

People

(Reporter: xti, Assigned: aaronmt)

References

Details

Attachments

(2 files, 3 obsolete files)

Attached image screenshot
Build id : Mozilla/5.0 (Android;Linux armv7l;rv:8.0a1)Gecko/20110808
Firefox/8.0a1 Fennec/8.0a1
Device: HTC Desire Z
OS: Android 2.3.3

Due to bug 659457, the site panel's text should be black for Gingerbread theme, but actually is white colored as you can see in the attached screenshot.
Attached patch Patch v1 (inverse text color) (obsolete) — Splinter Review
+ color: @color_text_inverse@;
Assignee: nobody → aaron.train
Status: NEW → ASSIGNED
Attachment #551762 - Flags: review?(mark.finkle)
Attached patch Patch v1 (inverse text color) (obsolete) — Splinter Review
wrong commit message
Attachment #551762 - Attachment is obsolete: true
Attachment #551762 - Flags: review?(mark.finkle)
Attachment #551764 - Flags: review?(mark.finkle)
Attached patch Patch v1 (inverse text color) (obsolete) — Splinter Review
Attachment #551764 - Attachment is obsolete: true
Attachment #551764 - Flags: review?(mark.finkle)
Attachment #551766 - Flags: review?(mark.finkle)
Comment on attachment 551766 [details] [diff] [review]
Patch v1 (inverse text color)

This would work, but I don't think we want to tie this to color_text_inverse. Since the background has a specific name, we'll make a new named color for the text too: color_text_panel

Can you add color_text_panel to gingerbread/defines.inc and use it here?
Attachment #551766 - Flags: review?(mark.finkle)
Attachment #551766 - Attachment is obsolete: true
Attachment #551974 - Flags: review?(mark.finkle)
Attachment #551974 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/mozilla-central/rev/4750c8153a55
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 8
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.