Implement WebIDL array types

RESOLVED WONTFIX

Status

()

Core
XPCOM
RESOLVED WONTFIX
7 years ago
5 years ago

People

(Reporter: ted, Unassigned)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

7 years ago
These would be useful. I'd like to use them. Once we kill off the C implementation of xpidl this won't be too hard.
(Reporter)

Comment 1

7 years ago
Created attachment 551530 [details] [diff] [review]
Support WebIDL array types in xpidl.py parser

This patch adds the necessary parsing changes to xpidl.py to handle WebIDL array types. I also added a small test suite for the parser. It's nowhere near comprehensive, but it tests around the areas I was changing, so it made me feel better.

This isn't actually useful yet, as it needs to be hooked up to header.py and the patch that hasn't been finished yet for bug 458936. We'll want to handle Array types by synthesizing an additional length parameter, presumably. (Unless we want to go crazy and make xptcall handle nsTArray or something neat like that.)
(Reporter)

Updated

7 years ago
Depends on: 458936
(Reporter)

Comment 2

7 years ago
I split the tests off into their own patch.
(Reporter)

Updated

7 years ago
Depends on: 677671
(Reporter)

Comment 3

7 years ago
Created attachment 551877 [details] [diff] [review]
Support WebIDL array types in xpidl.py parser

On top of the patch from the other bug. We might not actually want to take this. khuey and I have been talking, and we may fork the xpidl.py parser to make a webidl.py parser, so as not to intermingle all the legacy xpidl crap in with WebIDL.
(Reporter)

Updated

7 years ago
Attachment #551530 - Attachment is obsolete: true
(In reply to Ted Mielczarek [:ted, :luser] from comment #3)
> Created attachment 551877 [details] [diff] [review]
> Support WebIDL array types in xpidl.py parser
> 
> On top of the patch from the other bug. We might not actually want to take
> this. khuey and I have been talking, and we may fork the xpidl.py parser to
> make a webidl.py parser, so as not to intermingle all the legacy xpidl crap
> in with WebIDL.

That sounds like a decent idea.
(Reporter)

Updated

7 years ago
Assignee: ted.mielczarek → nobody
Is there a timeline for the WebIDL parser?
(Reporter)

Comment 7

5 years ago
We totally have a separate WebIDL parser now, so use that.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.