Closed Bug 677345 Opened 13 years ago Closed 13 years ago

when Thunderbird is unfocused, the menubar is hard to read

Categories

(Thunderbird :: Theme, defect)

Product:
Thunderbird
Component:
Theme
Platform:
x86
Windows Vista
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird6+ fixed, thunderbird7+ fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 8.0
Tracking Flags:
Tracking Status
thunderbird6 + fixed
thunderbird7 + fixed

People

(Reporter: andreasn, Assigned: Paenglab)

References

Details

Attachments

(4 files)

Thunderbird and Firefox menus
210.63 KB, image/png
Details
Readability patch
2.19 KB, patch
bwinton
: review+
andreasn
: ui-review+
Details | Diff | Splinter Review
Readability patch for comm-aurora
2.19 KB, patch
standard8
: approval-comm-aurora+
Details | Diff | Splinter Review
Readability patch for comm-beta
2.19 KB, patch
dkl
: approval-comm-beta+
Details | Diff | Splinter Review 
It's currently quite fuzzy.
Fuzzyness at the bottom
Depends on: 667248
Since this is effectively a spin-off from bug 667248, I've set the dependencies respectively. Please make any other follow-up bugs dependent on bug 667248 so that people know which issues are covered where.
Blocks: 645294
This patch leaves the white background also in inactive state. It also leaves the menu text color readable (color: MenuText)
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #551568 - Flags: ui-review?(nisses.mail)
Attachment #551568 - Flags: review?(bwinton)
Comment on attachment 551568 [details] [diff] [review]
Readability patch

As discussed on IRC, I'm happy with this now ui-wise.
Attachment #551568 - Flags: ui-review?(nisses.mail) → ui-review+
Comment on attachment 551568 [details] [diff] [review]
Readability patch

Review of attachment 551568 [details] [diff] [review]:
-----------------------------------------------------------------

The code looks good to me.

Thanks,
Blake.
Attachment #551568 - Flags: review?(bwinton) → review+
Checked into trunk:

http://hg.mozilla.org/comm-central/rev/aa02408a5fdb
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
tracking-thunderbird6: --- → +
tracking-thunderbird7: --- → +
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 8.0

        Attachment #551578 -
        Flags: approval-comm-aurora?

    
    

    
  


  

        Attachment #551580 -
        Flags: approval-comm-beta?

    
    

    
  
Comment on attachment 551578 [details] [diff] [review]
Readability patch for comm-aurora

Checked in: http://hg.mozilla.org/releases/comm-aurora/rev/f323eeb4e6bc

        Attachment #551578 -
        Flags: approval-comm-aurora? → approval-comm-aurora+

    
    

    
  
Comment on attachment 551580 [details] [diff] [review]
Readability patch for comm-beta

Checked in: http://hg.mozilla.org/releases/comm-beta/rev/f7d3f0828c66

        Attachment #551580 -
        Flags: approval-comm-beta? → approval-comm-beta+

    
    

    
  
Comment on attachment 551580 [details] [diff] [review]
Readability patch for comm-beta

Adding approval flag that was mistakenly removed. dkl

        Attachment #551580 -
        Flags: approval-comm-beta+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: