Closed
Bug 677412
Opened 13 years ago
Closed 13 years ago
Improve error handling in HandleMultipleAttachments
Categories
(Thunderbird :: Mail Window Front End, defect)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 8.0
People
(Reporter: squib, Assigned: squib)
Details
Attachments
(1 file)
|
14.15 KB,
patch
|
protz
:
review+
|
Details | Diff | Splinter Review |
Currently, if an error is encountered in HandleMultipleAttachments, it just dumps some (very vague) output to the command line. Instead, we should just throw an error and let it go into the error console. I believe this will also help Conversations, since protz mentioned he'd like to have this function throw an error when it fails.
Attached is a patch to fix this; I also switched the "Couldn't open external attachment!" error to get logged in the Error Console for consistency. There shouldn't be any behavioral changes to the code, and everything should already be covered by other tests.
Attachment #551616 -
Flags: review?(jonathan.protzenko)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 551616 [details] [diff] [review]
Improve error handling
Review of attachment 551616 [details] [diff] [review]:
-----------------------------------------------------------------
Looks pretty straightforward. I've tested this and it actually seems to work fine, so thanks for taking care of this!
Attachment #551616 -
Flags: review?(jonathan.protzenko) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 8.0
You need to log in
before you can comment on or make changes to this bug.
Description
•