Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Force an early failure when check-sync-dirs.py fails

RESOLVED FIXED in mozilla9

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

(Depends on: 1 bug)

Other Branch
mozilla9
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-bs)

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
We've had many perma oranges on the tree because of check-sync-dirs.py failing during make check, which happens after the build. At which time several other pushes are very likely to have occurred.
It would be better to fail early, and even better, to fail on local builds too, so that it's even less likely to happen.
(Assignee)

Comment 1

6 years ago
Created attachment 551805 [details] [diff] [review]
Force an early failure when check-sync-dirs.py fails
Attachment #551805 - Flags: review?(ted.mielczarek)
Comment on attachment 551805 [details] [diff] [review]
Force an early failure when check-sync-dirs.py fails

Review of attachment 551805 [details] [diff] [review]:
-----------------------------------------------------------------

This is a good idea. Not sure why we didn't think of this before. We should probably get a hg hook setup to just prevent pushing this stuff in the first place.
Attachment #551805 - Flags: review?(ted.mielczarek) → review+
Assignee: nobody → mh+mozilla
(Assignee)

Comment 3

6 years ago
(In reply to Ted Mielczarek [:ted, :luser] from comment #2)
> This is a good idea. Not sure why we didn't think of this before. We should
> probably get a hg hook setup to just prevent pushing this stuff in the first
> place.

The problem with a hg hook is that it would need to check out the files, or if it doesn't, it would need to completely reimplement the test to use the information available through the changesets. Sounds like a lot of possible complications.
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/projects/build-system/rev/c5f8cb2c8ea4
Whiteboard: fixed-in-bs
We'd have to rewrite the tests, yes, but it'd just be a matter of checking that the diffs match for files changed in those dirs. (with a list of exceptions to skip.)
http://hg.mozilla.org/mozilla-central/rev/c5f8cb2c8ea4
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Fwiw, this breaks the build on systems where there's no 'python' in the path, i now need to add mk_add_options PYTHON=/usr/local/bin/python2.7 to my .mozconfig before running gmake -f client.mk configure.

Can't it reuse the PYTHON var detected by configure itself ?
Yes, it should.  I'll r+ a patch for that ...
Actually, we can't just use python here, because it's in client.mk :-/
Depends on: 680871
(Assignee)

Comment 10

6 years ago
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #9)
> Actually, we can't just use python here, because it's in client.mk :-/

We do use python in client.mk, for MOZ_BUILD_DATE
Target Milestone: mozilla9 → mozilla8
Version: Trunk → Other Branch
(Assignee)

Updated

6 years ago
Target Milestone: mozilla8 → mozilla9
Not early enough though, because it doesn't happen until you've finished waiting for configure to finish, so I just wasted half an hour...
You need to log in before you can comment on or make changes to this bug.