Closed
Bug 680871
Opened 14 years ago
Closed 8 years ago
Force an early failure when check-sync-dirs.py use python2
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: fcellier, Unassigned)
References
Details
Attachments
(1 file)
|
2.24 KB,
patch
|
Details | Diff | Splinter Review |
client.mk use the default python (in my case python3) and js/src/config/check-sync-dirs.py is only compatible with python2.
Now the check force early failure so the compilation doesn't work anymore (https://bugzilla.mozilla.org/show_bug.cgi?id=677577)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Blocks: 677577
Assignee: nobody → mh+mozilla
|
||
Comment 1•14 years ago
|
||
I see several options:
- Only run the test on tinderboxes
- Do the same python detection in client.mk as what is done in configure.in
- Delay the check for build until after running configure, and use PYTHON from config/autoconf.mk
Kyle, which one would you prefer?
Number 3. We can probably run the test in build/ or config/ or something.
|
|
||
Comment 4•8 years ago
|
||
check-sync-dirs was removed in bug 950298.
Assignee: mh+mozilla → nobody
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•