67810 - javascript strict warnings in navigatorDD.js

Status: RESOLVED WORKSFORME

(Core :: DOM: Copy & Paste and Drag & Drop, defect, P4)

Description

[Henrik Gemal]

JavaScript strict warning:
chrome://navigator/content/navigatorDD.js line 108: reference to undefined 
property aDragSession.sourceElement

JavaScript error:
chrome://navigator/content/navigatorDD.js line 249: aElement has no properties

Comment 1

[Chris McAfee]

over to ben, adding alecf.

Comment 2

[Blake Ross]

-> xpapps dnd

Comment 3

[Blake Ross]

Henrik, can you still reproduce this?

Comment 4

[Henrik Gemal]

yeps...
if you have folders in your personal toolbar. Then try to drag a subfolder of a 
folder in the personal toolbar to the content area you get:

JavaScript strict warning:
chrome://navigator/content/navigatorDD.js line 108: reference to undefined 
property aDragSession.sourceElement

JavaScript error:
chrome://navigator/content/navigatorDD.js line 249: aElement has no properties

build 20010426

Comment 5

[Alec Flett]

those errors are due to bug 46456

Comment 6

[Blake Ross]

then --> hewitt (owner of that bug)

Comment 7

[Joe Hewitt (gone)]

these are fixed now

Comment 8

[Henrik Gemal]

I cant see the warnings with todays build 20010619.
Will reopen if I see them again.

Please add the following line to your prefs.js file, so we could avoid all 
these strict warning fixup...:
user_pref("javascript.options.strict", true);

Comment 9

[Henrik Gemal]

Warning: anonymous function does not always return a value
Source File: chrome://navigator/content/navigatorDD.js
Line: 255, Column: 18

Please add the following line to your prefs.js file, so we could avoid all 
these strict warning fixup...:
user_pref("javascript.options.strict", true);

Comment 10

[Alex Vincent [:WeirdAl]]

Reporter:  Can you reproduce this in a recent build?  I don't see a way to
easily reproduce this strict JS warning.  Also, looking at the function line 255
of
http://lxr.mozilla.org/seamonkey/source/xpfe/browser/resources/content/navigatorDD.js
is in, and the two adjoining functions, I do not see anything which would cause
this particular strict warning.

This bug hasn't been commented on in about 5 months.  It could be the above
strict warning is no longer valid.

Comment 11

[Henrik Gemal]

drag a link from a webpage to the Search button and you'll get:

Warning: reference to undefined property xferData[1]
Source File: chrome://navigator/content/navigatorDD.js
Line: 422

Warning: assignment to undeclared variable kNC_Name
Source File: chrome://navigator/content/navigator.js
Line: 665

Warning: assignment to undeclared variable defaultEngine
Source File: chrome://navigator/content/navigator.js
Line: 667

20020117

Comment 12

[Terri Preston]

qa contact -> pmac

Comment 13

[Philip Chee]

WFM:
Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.9.1b4pre) Gecko/20090305 SeaMonkey/2.0b1pre