Closed Bug 678108 Opened 8 years ago Closed 8 years ago

The favorite icon (star) does not fill in when using Tablet UI Forced

Categories

(Firefox for Android Graveyard :: General, defect, P3)

Firefox 8
ARM
Android
defect

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 8

People

(Reporter: nhirata, Assigned: mbrubeck)

References

Details

(Whiteboard: [inbound])

Attachments

(1 file)

1. set ("browser.ui.layout.tablet" = -1) 
2. click on the favorite icon (star)
3. select edit
4. click done

Expected: the star fills
Actual: the star doesn't fill

Youtube vid: http://www.youtube.com/watch?v=PON6uL9F8EM

Mozilla/5.0 (Android; Linux armv71; rv8.0a1) Gecko/20110810 Firefox/8.0a1 Fennec/8.0a1
Device: HTC Flyer 
OS: Android 2.3

Note:
1. I restart the app as well as restarted the device and still the thing does not fill on favorite web sites, nor when bookmarking.
Priority: -- → P3
Works for me using the current nightly on a Transformer and the Ideos s7 with the tablet ui enabled.
Attached patch patchSplinter Review
I missed a change in the Gingerbread theme CSS.
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
Attachment #553254 - Flags: review?(wjohnston)
Attachment #553254 - Flags: review?(wjohnston) → review+
Blocks: 656329
Version: Firefox 7 → Firefox 8
http://hg.mozilla.org/mozilla-central/rev/0f43479bf279
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 8
(In reply to Naoki Hirata :nhirata from comment #0)
> 1. set ("browser.ui.layout.tablet" = -1) 

How do you set this preference as -1? I've tried to set it as you mentioned at step 1, but I was not able to change it below 0. 

--
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110901
Firefox/9.0a1 Fennec/9.0a1
Device: Acer ICONIA TAB A500
OS: Android 3.1
(In reply to Cristian Nicolae (:xti) from comment #5)
> (In reply to Naoki Hirata :nhirata from comment #0)
> > 1. set ("browser.ui.layout.tablet" = -1) 
> 
> How do you set this preference as -1? I've tried to set it as you mentioned
> at step 1, but I was not able to change it below 0. 
> 

I've tried it on the latest Aurora build.
 --
 Mozilla/5.0 (Android;Linux armv7l;rv:8.0a1)Gecko/20110901
 Firefox/8.0a1 Fennec/8.0a1
 Device: Acer ICONIA TAB A500
 OS: Android 3.1
(In reply to Cristian Nicolae (:xti) from comment #5)
> How do you set this preference as -1? I've tried to set it as you mentioned
> at step 1, but I was not able to change it below 0. 

This is bug 679120 which is fixed in Nightly but not Aurora.   For Aurora, you can set it to 1 instead, which should have the same effect.
Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:8.0a1)Gecko/20110901
Firefox/8.0a1 Fennec/8.0a1
Device: Acer ICONIA TAB A500
OS: Android 3.1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.