Closed
Bug 678178
Opened 14 years ago
Closed 14 years ago
Update endurance shared module to reflect rename of micro-iterations to entities
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: davehunt, Assigned: davehunt)
References
Details
(Whiteboard: [lib])
Attachments
(1 file, 2 obsolete files)
|
3.12 KB,
patch
|
whimboo
:
review+
|
Details | Diff | Splinter Review |
We need to update the endurance shared module to reflect rename of micro-iterations to entities.
|
Assignee | |
Updated•14 years ago
|
|
|
Assignee | |
Comment 1•14 years ago
|
||
Assignee: nobody → dave.hunt
Attachment #553217 -
Flags: review?(hskupin)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 553217 [details] [diff] [review]
Update endurance shared module to reflect rename of micro-iterations to entities. v1.0
>+ entity : function endurance_entity(callback) {
Same as mentioned in the other review. We need an action here. A noun doesn't visualize a method but a property.
Attachment #553217 -
Flags: review?(hskupin) → review-
|
|
Assignee | |
Comment 3•14 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #2)
> Comment on attachment 553217 [details] [diff] [review]
> Update endurance shared module to reflect rename of micro-iterations to
> entities. v1.0
>
> >+ entity : function endurance_entity(callback) {
>
> Same as mentioned in the other review. We need an action here. A noun
> doesn't visualize a method but a property.
Reverted to loop as discussed on IRC.
Attachment #553217 -
Attachment is obsolete: true
Attachment #553415 -
Flags: review?(hskupin)
|
|
Assignee | |
Comment 4•14 years ago
|
||
Updated comment as discussed on IRC.
Attachment #553415 -
Attachment is obsolete: true
Attachment #553415 -
Flags: review?(hskupin)
Attachment #553417 -
Flags: review?(hskupin)
|
|
||
Comment 5•14 years ago
|
||
Comment on attachment 553417 [details] [diff] [review]
Update endurance shared module to reflect rename of micro-iterations to entities. v1.2
Looks good. Thanks Dave.
Attachment #553417 -
Flags: review?(hskupin) → review+
|
|
Assignee | |
Comment 6•14 years ago
|
||
Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/04403602970a (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/30d4b892f218 (mozilla-aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/81e152a988c4 (mozilla-beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/d3aa6104d3e5 (mozilla-release)
http://hg.mozilla.org/qa/mozmill-tests/rev/cb285b91c8a2 (mozilla-2.0)
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
||
Updated•13 years ago
|
Component: Mozmill Shared Modules → Mozmill Tests
|
|
||
Updated•13 years ago
|
Whiteboard: [lib]
|
||
Updated•6 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•