Update endurance shared module to reflect rename of micro-iterations to entities

RESOLVED FIXED

Status

Mozilla QA
Mozmill Tests
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: davehunt, Assigned: davehunt)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lib])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

7 years ago
We need to update the endurance shared module to reflect rename of micro-iterations to entities.
(Assignee)

Updated

7 years ago
Depends on: 678175
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Updated

7 years ago
Blocks: 678180
(Assignee)

Comment 1

7 years ago
Created attachment 553217 [details] [diff] [review]
Update endurance shared module to reflect rename of micro-iterations to entities. v1.0
Assignee: nobody → dave.hunt
Attachment #553217 - Flags: review?(hskupin)
Comment on attachment 553217 [details] [diff] [review]
Update endurance shared module to reflect rename of micro-iterations to entities. v1.0

>+  entity : function endurance_entity(callback) {

Same as mentioned in the other review. We need an action here. A noun doesn't visualize a method but a property.
Attachment #553217 - Flags: review?(hskupin) → review-
(Assignee)

Comment 3

7 years ago
Created attachment 553415 [details] [diff] [review]
Update endurance shared module to reflect rename of micro-iterations to entities. v1.1

(In reply to Henrik Skupin (:whimboo) from comment #2)
> Comment on attachment 553217 [details] [diff] [review]
> Update endurance shared module to reflect rename of micro-iterations to
> entities. v1.0
> 
> >+  entity : function endurance_entity(callback) {
> 
> Same as mentioned in the other review. We need an action here. A noun
> doesn't visualize a method but a property.

Reverted to loop as discussed on IRC.
Attachment #553217 - Attachment is obsolete: true
Attachment #553415 - Flags: review?(hskupin)
(Assignee)

Comment 4

7 years ago
Created attachment 553417 [details] [diff] [review]
Update endurance shared module to reflect rename of micro-iterations to entities. v1.2

Updated comment as discussed on IRC.
Attachment #553415 - Attachment is obsolete: true
Attachment #553415 - Flags: review?(hskupin)
Attachment #553417 - Flags: review?(hskupin)
Comment on attachment 553417 [details] [diff] [review]
Update endurance shared module to reflect rename of micro-iterations to entities. v1.2

Looks good. Thanks Dave.
Attachment #553417 - Flags: review?(hskupin) → review+
Component: Mozmill Shared Modules → Mozmill Tests
Whiteboard: [lib]
You need to log in before you can comment on or make changes to this bug.