Closed Bug 678178 Opened 11 years ago Closed 11 years ago

Update endurance shared module to reflect rename of micro-iterations to entities

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: davehunt, Assigned: davehunt)

References

Details

(Whiteboard: [lib])

Attachments

(1 file, 2 obsolete files)

We need to update the endurance shared module to reflect rename of micro-iterations to entities.
Depends on: 678175
OS: Mac OS X → All
Hardware: x86 → All
Blocks: 678180
Assignee: nobody → dave.hunt
Attachment #553217 - Flags: review?(hskupin)
Comment on attachment 553217 [details] [diff] [review]
Update endurance shared module to reflect rename of micro-iterations to entities. v1.0

>+  entity : function endurance_entity(callback) {

Same as mentioned in the other review. We need an action here. A noun doesn't visualize a method but a property.
Attachment #553217 - Flags: review?(hskupin) → review-
(In reply to Henrik Skupin (:whimboo) from comment #2)
> Comment on attachment 553217 [details] [diff] [review]
> Update endurance shared module to reflect rename of micro-iterations to
> entities. v1.0
> 
> >+  entity : function endurance_entity(callback) {
> 
> Same as mentioned in the other review. We need an action here. A noun
> doesn't visualize a method but a property.

Reverted to loop as discussed on IRC.
Attachment #553217 - Attachment is obsolete: true
Attachment #553415 - Flags: review?(hskupin)
Updated comment as discussed on IRC.
Attachment #553415 - Attachment is obsolete: true
Attachment #553415 - Flags: review?(hskupin)
Attachment #553417 - Flags: review?(hskupin)
Comment on attachment 553417 [details] [diff] [review]
Update endurance shared module to reflect rename of micro-iterations to entities. v1.2

Looks good. Thanks Dave.
Attachment #553417 - Flags: review?(hskupin) → review+
Component: Mozmill Shared Modules → Mozmill Tests
Whiteboard: [lib]
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.