678178 - Update endurance shared module to reflect rename of micro-iterations to entities

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

We need to update the endurance shared module to reflect rename of micro-iterations to entities.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Update endurance shared module to reflect rename of micro-iterations to entities. v1.0

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 553217 [details] [diff] [review]
Update endurance shared module to reflect rename of micro-iterations to entities. v1.0

>+  entity : function endurance_entity(callback) {

Same as mentioned in the other review. We need an action here. A noun doesn't visualize a method but a property.

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Update endurance shared module to reflect rename of micro-iterations to entities. v1.1

(In reply to Henrik Skupin (:whimboo) from comment #2)
> Comment on attachment 553217 [details] [diff] [review]
> Update endurance shared module to reflect rename of micro-iterations to
> entities. v1.0
> 
> >+  entity : function endurance_entity(callback) {
> 
> Same as mentioned in the other review. We need an action here. A noun
> doesn't visualize a method but a property.

Reverted to loop as discussed on IRC.

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Update endurance shared module to reflect rename of micro-iterations to entities. v1.2

Updated comment as discussed on IRC.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 553417 [details] [diff] [review]
Update endurance shared module to reflect rename of micro-iterations to entities. v1.2

Looks good. Thanks Dave.

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/04403602970a (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/30d4b892f218 (mozilla-aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/81e152a988c4 (mozilla-beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/d3aa6104d3e5 (mozilla-release)
http://hg.mozilla.org/qa/mozmill-tests/rev/cb285b91c8a2 (mozilla-2.0)