Update endurance tests to use entities rather than loop/micro-iteration

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
7 years ago
7 years ago

People

(Reporter: davehunt, Assigned: davehunt)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Once the shared module is updated we will need to update the tests to use the new naming for entities.

Comment 1

7 years ago
A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/16887381
Created attachment 553219 [details] [diff] [review]
Update endurance tests to use entities rather than loop/micro-iteration. v1.0
Assignee: nobody → dave.hunt
Attachment #553219 - Flags: review?(hskupin)
Comment on attachment 553219 [details] [diff] [review]
Update endurance tests to use entities rather than loop/micro-iteration. v1.0

entity is a subject but no action. Functions should always represent an action. We have to find something else as 'entity' to use.
Attachment #553219 - Flags: review?(hskupin) → review-
Can you make a suggestion? I can revert back to loop?
Reverted to loop, making this patch unnecessary.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WONTFIX
No big opinion on this either way, but just noting that I was reminded by the closure discussion that functions can also be named after what they return (i.e. sometimes they're named after results and not actions).

Internally, loop is probably fine; generally loops should create entities.

Comment 7

7 years ago
Dave Hunt deleted the linked story in Pivotal Tracker
You need to log in before you can comment on or make changes to this bug.