Closed
Bug 678180
Opened 14 years ago
Closed 14 years ago
Update endurance tests to use entities rather than loop/micro-iteration
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: davehunt, Assigned: davehunt)
References
Details
Attachments
(1 file)
|
1.85 KB,
patch
|
whimboo
:
review-
|
Details | Diff | Splinter Review |
Once the shared module is updated we will need to update the tests to use the new naming for entities.
A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/16887381
|
Assignee | |
Comment 2•14 years ago
|
||
Assignee: nobody → dave.hunt
Attachment #553219 -
Flags: review?(hskupin)
|
||
Comment 3•14 years ago
|
||
Comment on attachment 553219 [details] [diff] [review]
Update endurance tests to use entities rather than loop/micro-iteration. v1.0
entity is a subject but no action. Functions should always represent an action. We have to find something else as 'entity' to use.
Attachment #553219 -
Flags: review?(hskupin) → review-
|
|
Assignee | |
Comment 4•14 years ago
|
||
Can you make a suggestion? I can revert back to loop?
|
|
Assignee | |
Comment 5•14 years ago
|
||
Reverted to loop, making this patch unnecessary.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WONTFIX
No big opinion on this either way, but just noting that I was reminded by the closure discussion that functions can also be named after what they return (i.e. sometimes they're named after results and not actions).
Internally, loop is probably fine; generally loops should create entities.
|
||
Updated•6 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•