678207 - With GL layers enabled, Fennec crashes on startup

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Ali Juma [:ajuma]]

On the current (August 11) Nightly, if GL Layers are enabled, Fennec always crashes on startup.

Regression range:
The crash occurs with http://hg.mozilla.org/mozilla-central/rev/93328efd3d77
but not with http://hg.mozilla.org/mozilla-central/rev/aee7dcfde223

Comment 1

[Benoit Girard (:BenWa)]

We need to find the specific changeset.

A wild guess might be the changes for Bug 648484.

Comment 2

[Ali Juma [:ajuma]]

(In reply to Benoit Girard (:BenWa) from comment #1)
> We need to find the specific changeset.
> 
> A wild guess might be the changes for Bug 648484.

Yes, this is indeed caused by one of the changes for Bug 648484. I'm working on finding which one.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

This is bad.  What's the crash?

Comment 4

[Ali Juma [:ajuma]]

It turns out that as result of the changes to the interface of GetLayerManager in part 3 of bug 648484, calls in nsWindow.cpp to GetLayerManager(nsnull) were going to nsBaseWidget::GetLayerManager instead of nsWindow::GetLayerManager as defined in nsWindow.cpp. As a result, sGLContext in nsWindow.cpp was never initialized, and we crashed when attempting to dereference it in nsWindow::OnDraw.

Patch on its way.

Comment 5

[Ali Juma [:ajuma]]

Attachment: Fix interface of nsWindow::GetLayerManager on Android

This makes the interface of GetLayerManager on Android consistent with the changes introduced in Bug 648484.

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 552502 [details] [diff] [review]
Fix interface of nsWindow::GetLayerManager on Android

Nice.

Comment 7

[Benoit Girard (:BenWa)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/5a85aeba5c59

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/5a85aeba5c59