Last Comment Bug 678207 - With GL layers enabled, Fennec crashes on startup
: With GL layers enabled, Fennec crashes on startup
Status: RESOLVED FIXED
: regression
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: ARM Android
: -- normal (vote)
: mozilla8
Assigned To: Ali Juma [:ajuma]
:
Mentors:
Depends on:
Blocks: opengl-mobile 648484
  Show dependency treegraph
 
Reported: 2011-08-11 08:47 PDT by Ali Juma [:ajuma]
Modified: 2011-08-14 04:51 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix interface of nsWindow::GetLayerManager on Android (2.08 KB, patch)
2011-08-11 14:24 PDT, Ali Juma [:ajuma]
cjones.bugs: review+
Details | Diff | Review

Description Ali Juma [:ajuma] 2011-08-11 08:47:45 PDT
On the current (August 11) Nightly, if GL Layers are enabled, Fennec always crashes on startup.

Regression range:
The crash occurs with http://hg.mozilla.org/mozilla-central/rev/93328efd3d77
but not with http://hg.mozilla.org/mozilla-central/rev/aee7dcfde223
Comment 1 Benoit Girard (:BenWa) 2011-08-11 09:11:23 PDT
We need to find the specific changeset.

A wild guess might be the changes for Bug 648484.
Comment 2 Ali Juma [:ajuma] 2011-08-11 09:14:09 PDT
(In reply to Benoit Girard (:BenWa) from comment #1)
> We need to find the specific changeset.
> 
> A wild guess might be the changes for Bug 648484.

Yes, this is indeed caused by one of the changes for Bug 648484. I'm working on finding which one.
Comment 3 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-08-11 12:04:20 PDT
This is bad.  What's the crash?
Comment 4 Ali Juma [:ajuma] 2011-08-11 13:57:06 PDT
It turns out that as result of the changes to the interface of GetLayerManager in part 3 of bug 648484, calls in nsWindow.cpp to GetLayerManager(nsnull) were going to nsBaseWidget::GetLayerManager instead of nsWindow::GetLayerManager as defined in nsWindow.cpp. As a result, sGLContext in nsWindow.cpp was never initialized, and we crashed when attempting to dereference it in nsWindow::OnDraw.

Patch on its way.
Comment 5 Ali Juma [:ajuma] 2011-08-11 14:24:58 PDT
Created attachment 552502 [details] [diff] [review]
Fix interface of nsWindow::GetLayerManager on Android

This makes the interface of GetLayerManager on Android consistent with the changes introduced in Bug 648484.
Comment 6 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-08-11 14:38:00 PDT
Comment on attachment 552502 [details] [diff] [review]
Fix interface of nsWindow::GetLayerManager on Android

Nice.
Comment 8 Kyle Huey [:khuey] (khuey@mozilla.com) (Away until 6/13) 2011-08-14 04:51:50 PDT
http://hg.mozilla.org/mozilla-central/rev/5a85aeba5c59

Note You need to log in before you can comment on or make changes to this bug.